Modify

Opened 4 years ago

Closed 4 years ago

#2343 closed defect (fixed)

[PATCH] Area joining fails with special setup

Reported by: stoecker Owned by: xeen
Priority: minor Component: Plugin
Version: Keywords:
Cc:

Description

When joining the two ways 24925550 and 23333420 the tool to join areas forgets one line.

Attachments (3)

Adjacent Areas Testcase.osm (3.0 KB) - added by xeen 4 years ago.
Fix JoinAreas.patch (7.4 KB) - added by xeen 4 years ago.
Update JoinAreas Testfile.patch (66.2 KB) - added by xeen 4 years ago.

Download all attachments as: .zip

Change History (5)

Changed 4 years ago by xeen

Changed 4 years ago by xeen

Changed 4 years ago by xeen

comment:1 Changed 4 years ago by xeen

  • Summary changed from Area joining fails with special setup to [PATCH] Area joining fails with special setup

The patch fixes the following:

  • Undo/Redo action description wasn't really translatable due to area names being included in the String.
  • Prevents duplicates when searching for inner ways
  • Fixed the issue here by explicitly working around it (normally the missing piece should be combined with the outer way, but since this only happens for two-node ways and since it's hard to find those "useful" two-nodes ways, it simply connects first and last node of the outer way which achieves the same).
  • Adds more checks for uninteresting/wrong ways when fixing multipolygons (it sometimes broke the testcase in the lower middle).
  • Made makeCommitsOneAction not produce an error if for some reason the action count is longer than the undo buffer.

comment:2 Changed 4 years ago by stoecker

  • Resolution set to fixed
  • Status changed from new to closed

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.