[PATCH] Useless space in RelationEditor

[stoecker]

For unknown reason there is too much free space above the OK/Cancel buttons in relation editor.

[stoecker]

Also the Buttons in RelationEditor should use SideButton and correct shortcut calls instead of own createButton function.

[xeen]

My guess the additional space comes from adding an "empty" JOptionPane instead of adding buttons properly. I'll see if I can tune ExtendedDialog a bit so it's better inheritable.

[xeen]

Depends on Patch in #2122 (changes to ExtendedDialog)

[xeen]

This patch makes RelationEditor use ExtendedDialog (therefore this depends on the patch in #2122 because it makes ExtendedDialog inherit-friendly) and SideButtons.

It refactors the code a bit to make the constructor easier to extend/read.

This patch introduces new FIXMEs:

• Remember last window position and size (won't work on this)
• Shortcuts only configurable after Relation Editor has been opened at least once (or they are already customized and saved in prefs)
• RelEditor currently uses GROUP_LAYER because "dialog" is the closest match. It's a separate window and thus should be independent of the shortcuts in main JOSM. I decided it's not worth to hack something for the relation editor since this is a general issue (i.e. shortcut class should have methods to add/save/etc custom groups).

[stoecker]

Fixed in r1431.

You need to use GROUP_MNEMONIC, as buttons and menus do not support anything else than <ALT>+<.>.

Point two is valid for all other fields as well.

I added point 1 as another report.