Modify ↓

Ticket #2185 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

[PATCH] Various cleanup

Reported by: bruce89 <bcowan{at}fastmail{dot}co{dot}uk> Owned by: framm
Priority: minor Component: Core
Version: latest Keywords:
Cc:

Description

Here is a rather large patch which does a fair bit of cleaning up.

  • Removal of unused imports
  • Cleanup of javadoc comments
  • Parametrisation
  • Removal of unneeded casts
  • Slight string change (use of degree symbol instead of "degree")
  • Removal of unused methods
  • Proper use of static methods
  • Removal of useless history dialogue
  • Removal of fairly useless map mode (the old image one)

I have ignored FileDrop.java, as I think it is beyond hope, and it's probably best to leave it since it is from elsewhere.

Also, world.jpg and history.png from images can be removed.

Feel free to ignore certain parts of this patch.

Attachments

JOSM.patch.gz​ (14.2 KB) - added by bruce89 3 years ago.
Patch

Change History

Changed 3 years ago by bruce89

Patch

comment:1 Changed 3 years ago by anonymous

  • Summary changed from Various cleanup to [PATCH] Various cleanup

comment:2 Changed 3 years ago by stoecker

  • Status changed from new to closed
  • Resolution set to fixed

I removed the degree sign change and the worldchooser and history dialog killing.

Applied in r1415.

View ↑

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.