Modify

Opened 4 years ago

Closed 4 years ago

#1875 closed defect (fixed)

[PATCH] DirectUpload plugin incorrectly encodes the OSM username: Users with non-ascii characters in their names can't upload traces

Reported by: anonymous Owned by: Subhodip Biswas
Priority: minor Component: Plugin
Version: latest Keywords:
Cc:

Description

My username is "Ævar Arnfjörð Bjarmason". When I try to use the DirectUpload plugin to upload traces with that username set in JOSM preferences the DirectUpload plugin will send an incorrect HTTP auth hash to the OSM server and it'll reject the upload.

This is related to #1797. DirectUpload doesn't seem to handle anything relating to encoding correctly.

Attachments (2)

EncodeUsernameCorrectly.patch (2.0 KB) - added by xeen 4 years ago.
Fix username encoding
DirectUpload.jar (61.8 KB) - added by xeen 4 years ago.
Compiled DirectUpload plugin with patch. Please test this.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 4 years ago by anonymous

  • Owner changed from framm to Subhodip Biswas

comment:2 Changed 4 years ago by xeen

  • Priority changed from major to minor

Here's a fix for this, I tested it with "xöön" and it works. Ironically, I couldn't upload normal data using JOSM integrated dialog.

Could someone please verify that the patch works? A compiled version is attach, just replace your old DirectUpload.jar and test :). If it works, please change the title to "[PATCH] …" so that it will get checked in.

As a temporary workaround you can still use your email address which probably doesn't contain any "special" chars.

Changed 4 years ago by xeen

Fix username encoding

Changed 4 years ago by xeen

Compiled DirectUpload plugin with patch. Please test this.

comment:3 Changed 4 years ago by avar

  • Summary changed from DirectUpload plugin incorrectly encodes the OSM username: Users with non-ascii characters in their names can't upload traces to [PATCH] DirectUpload plugin incorrectly encodes the OSM username: Users with non-ascii characters in their names can't upload traces

Tested, works for me.

comment:4 Changed 4 years ago by anonymous

  • Resolution set to fixed
  • Status changed from new to closed

Applied in 13634.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.