[Patch] Separate unique identifiers per primitive type

[Don-vip]

To solve #18653 I had to apply this patch so that we get rid of a unique id counter across all primitive types to get one per primitive type.

[simon04]

+1

Successfully tested uploading way/-1 consisting of node/-1 and node/-2 – ​https://api06.dev.openstreetmap.org/way/4305500424

[GerdP]

I don't understand how an upload is related to this. Isn't about stable negative ids so that when you save data to a file, load it again, add some objects and save it again the ids are not completely different?

[simon04]

I was unsure whether id=-1 could be used for a new node as well as a new way. That's what I've verified.

[Don-vip]

In 15820/josm:

fix #18654 - Separate unique identifiers per primitive type

This allows to easily update .osm files with negative ids across multiple sessions, such as internal JOSM boundaries file.

[GerdP]

It also helps a lot when debugging. Much easier to understand what's going on when ids don't change :)

[GerdP]

In 15822/josm:

see #18654: Fix unit test
OsmPrimitiveComparator.comparingUniqueId() no longer works because test creates a node with -1 and a way with -1 now. I see no need to store the elements in an unordered set and sort again later.