Opened 4 years ago
Closed 4 years ago
#1828 closed defect (fixed)
AgPifoJ: had a track opened and tried to open a folder of photos and got the error below
| Reported by: | aclearn@… | Owned by: | Christian Gallioz |
|---|---|---|---|
| Priority: | major | Component: | Plugin |
| Version: | latest | Keywords: | AgpifoJ |
| Cc: |
Description
I'm sing Ubuntu and tangoGPS on openmoko. I had a log.gpx.osm file opened and tried to import some photos. They were in a sub folder of my home folder, I selected the home folder and clicked open, the window (of files and folders -AgpifoJ) closed. After a minute I tried again to open File but it didn't respond after a few minutes the error message below appeared.
Path: trunk
URL: http://josm.openstreetmap.de/svn/trunk
Repository Root: http://josm.openstreetmap.de/svn
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Revision: 849
Node Kind: directory
Last Changed Author: stoecker
Last Changed Rev: 849
Last Changed Date: 2008-08-22 22:10:12 +0200 (Fri, 22 Aug 2008)
java.lang.NullPointerException
at org.openstreetmap.josm.plugins.agpifoj.AgpifojPlugin$Action.addRecursiveFiles(Unknown Source)
at org.openstreetmap.josm.plugins.agpifoj.AgpifojPlugin$Action.addRecursiveFiles(Unknown Source)
at org.openstreetmap.josm.plugins.agpifoj.AgpifojPlugin$Action.addRecursiveFiles(Unknown Source)
at org.openstreetmap.josm.plugins.agpifoj.AgpifojPlugin$Action.addRecursiveFiles(Unknown Source)
at org.openstreetmap.josm.plugins.agpifoj.AgpifojPlugin$Action.actionPerformed(Unknown Source)
at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1995)
at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2318)
at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:387)
at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:242)
at javax.swing.AbstractButton.doClick(AbstractButton.java:357)
at javax.swing.plaf.basic.BasicMenuItemUI.doClick(BasicMenuItemUI.java:1220)
at javax.swing.plaf.basic.BasicMenuItemUI$Handler.mouseReleased(BasicMenuItemUI.java:1261)
at java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:272)
at java.awt.Component.processMouseEvent(Component.java:6041)
at javax.swing.JComponent.processMouseEvent(JComponent.java:3265)
at java.awt.Component.processEvent(Component.java:5806)
at java.awt.Container.processEvent(Container.java:2058)
at java.awt.Component.dispatchEventImpl(Component.java:4413)
at java.awt.Container.dispatchEventImpl(Container.java:2116)
at java.awt.Component.dispatchEvent(Component.java:4243)
at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4322)
at java.awt.LightweightDispatcher.processMouseEvent(Container.java:3986)
at java.awt.LightweightDispatcher.dispatchEvent(Container.java:3916)
at java.awt.Container.dispatchEventImpl(Container.java:2102)
at java.awt.Window.dispatchEventImpl(Window.java:2440)
at java.awt.Component.dispatchEvent(Component.java:4243)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:599)
at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:273)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:183)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:173)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:168)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:160)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:121)
Attachments (0)
Change History (4)
comment:1 in reply to: ↑ description Changed 4 years ago by anonymous
comment:2 Changed 4 years ago by anonymous
- Summary changed from had a track opened and tried to open a folder of photos and got the error below to AgPifoJ: had a track opened and tried to open a folder of photos and got the error below
comment:3 Changed 4 years ago by stoecker
- Owner changed from framm to Christian Gallioz
comment:4 Changed 4 years ago by C.Gallioz
- Resolution set to fixed
- Status changed from new to closed
When selecting a directory, Agpifoj scans all the directory and subdirectories to find JPEG images. So, that may take many time when the directory contains a lot of subdirectories.
With the fix, Agpifoj scans the directories in a PleaseWaitRunnable class, so that a dialog displays the user which directory is being scanned, and gives him a chance to stop it.
To avoid the exception, null files are now detected (but I can't understand why that occurs), and an HashSet has been added to avoid Unix links loops.
Replying to aclearn@yahoo.co.uk:
I clicked the home icon in the window and it worked fine from the home directory. (noob josm user)