Modify ↓

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#17237 closed enhancement (fixed)

Save/Save As: Poor error handling with write protected files

Reported by: GerdP Owned by: team
Priority: normal Milestone: 19.04
Component: Core Version:
Keywords: template_report Cc:

Description (last modified by GerdP)

What steps will reproduce the problem?

  1. Open a write protected osm file
  2. Click Save

What is the expected result?

A single error message in a popup telling me that the file is write protected.

What happens instead?

Two popups:
1st says that the backup (file name with tilde) can't be saved
2nd says that the file can't be restored

Please provide any additional information below. Attach a screenshot if possible.

Similar problem when you select a write protected file in Save As.

Build-Date:2019-01-24 09:50:51
Revision:14726
Is-Local-Build:true

Identification: JOSM/1.5 (14726 SVN en) Windows 10 64-Bit
OS Build number: Windows 10 Home 1803 (17134)
Memory Usage: 540 MB / 1753 MB (284 MB allocated, but free)
Java version: 1.8.0_191-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080
VM arguments: [-agentlib:jdwp=transport=dt_socket,suspend=y,address=localhost:57267, -ea, -Dfile.encoding=UTF-8]
Program arguments: [--debug]

Plugins:
+ OpeningHoursEditor (34535)
+ apache-commons (34506)
+ buildings_tools (34850)
+ download_along (34838)
+ ejml (34389)
+ geotools (34513)
+ jaxb (34506)
+ jts (34524)
+ o5m (34846)
+ opendata (34805)
+ pbf (34858)
+ poly (34546)
+ reltoolbox (34788)
+ reverter (34552)
+ utilsplugin2 (34844)

Tagging presets:
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/INT-1-preset.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/Historical_Objects&zip=1

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- E: org.openstreetmap.josm.io.IllegalDataException: crosby.binary.file.FileFormatException: Unexpectedly long header 65536 bytes. Possibly corrupt file.. Cause: crosby.binary.file.FileFormatException: Unexpectedly long header 65536 bytes. Possibly corrupt file.
- E: Error - <html>Could not read file 'sample.osm.pbf'.<br>Error is:<br>crosby.binary.file.FileFormatException: Unexpectedly long header 65536 bytes. Possibly corrupt file.</html>
- E: org.openstreetmap.josm.io.IllegalDataException: crosby.binary.file.FileFormatException: Unexpectedly long header 65536 bytes. Possibly corrupt file.. Cause: crosby.binary.file.FileFormatException: Unexpectedly long header 65536 bytes. Possibly corrupt file.
- E: Error - <html>Could not read file 'sample.osm.pbf'.<br>Error is:<br>crosby.binary.file.FileFormatException: Unexpectedly long header 65536 bytes. Possibly corrupt file.</html>

Attachments (2)

popup1.PNG​ (6.7 KB ) - added by GerdP 5 years ago.
popup2.PNG​ (6.4 KB ) - added by GerdP 5 years ago.

Download all attachments as: .zip

Change History (5)

by GerdP, 5 years ago

Attachment: popup1.PNG​ added

by GerdP, 5 years ago

Attachment: popup2.PNG​ added

comment:1 by GerdP, 5 years ago

Description: modified (diff)

1st 2nd

comment:2 by GerdP, 5 years ago

Resolution: → fixed
Status: new → closed

In 14982/josm:

fix #17237: Poor error handling with write protected files

comment:3 by Klumbumbus, 5 years ago

Milestone: → 19.04

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.