Suspicious code in ImproveWayAccuracyAction.java

[GerdP]

I did not try it but I assume the 2nd list should use the data from getLastNode()?
If it is an error it exists since a long time.

                // Looking for candidateSegment copies in ways that are referenced by candidateSegment nodes
                List<Way> firstNodeWays = candidateSegment.getFirstNode().referrers(Way.class).collect(Collectors.toList());
                List<Way> secondNodeWays = candidateSegment.getFirstNode().referrers(Way.class).collect(Collectors.toList());

[simon04]

I also stumbled over this suspicious line, but wasn't sure whether this was intended or a bug.

[GerdP]

I am not sure if I understood what the code tries to find. The attached patch removes some lines and seems to produce the same results. The unit test also doesn't show what the action is expected to do :-(

[GerdP]

In 14670/josm:

fix #17186: Simplify code in ImproveWayAccuracyAction