Modify ↓

Opened 5 years ago

Closed 4 years ago

#1635 closed defect (fixed)

[PATCH] NullPointer in DirectUpload Plugin

Reported by: nagi@… Owned by: xeen
Priority: trivial Component: Plugin
Version: latest Keywords: NullPointer; DirectUpload
Cc: stefan@…

Description

Hi
-using Tolls/Upload Traces with a GPX file.

  • Let tags empty (as this could be in the web frontend)

-> NPE

Regards

Attachments (2)

NPE_DirectUpload.txt​ (2.0 KB) - added by nagi@… 5 years ago.
NPE Stack Trace
ImproveDirectUploadPlugin.patch​ (21.6 KB) - added by xeen 4 years ago.
Improve Direct Upload Plugin

Download all attachments as: .zip

Change History (8)

Changed 5 years ago by nagi@…

NPE Stack Trace

comment:1 Changed 5 years ago by Subhodip Biswas <subhodipbiswas@…>

  • Owner changed from framm to anonymous
  • Status changed from new to assigned

comment:2 Changed 4 years ago by Hasienda

  • Keywords NullPointer DirectUpload added

#1637 is a duplicate ticket but still has a clearer error message, where it reads here "Unknown Source"

comment:3 Changed 4 years ago by stoecker

  • Owner changed from anonymous to Subhodip Biswas
  • Status changed from assigned to new

comment:4 Changed 4 years ago by anonymous

Duplicate: #1884

comment:6 Changed 4 years ago by xeen

  • Cc stefan@… added; ewzzGWVLRvbGDSV removed
  • Owner changed from Subhodip Biswas to xeen
  • Summary changed from NullPointer in DirectUpload Plugin to [PATCH] NullPointer in DirectUpload Plugin

I thought this was nice and easy…

The patch does the following:

  • use JOSM provided base64 converting
  • Dialog Facelift (center screen, borders, translatable, dialog title, etc.)
  • Fix indentation (and remove those "auto generate" comments)
  • Auto select GPX layer if only one is available (and copies filename to description)
  • Fix the NullPointer issue (hopefully I didn't introduce new ones)
  • Fix special character handling so that the upload doesn't fail

It's still far from perfect, most obviously it should use the main worker to upload instead of hanging when clicking "upload". Will probably add this in a later patch, it's not my top priority.



Changed 4 years ago by xeen

Improve Direct Upload Plugin

comment:7 Changed 4 years ago by anonymous

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in 13373.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.