Changes between Version 1 and Version 2 of Ticket #15709, comment 48
- Timestamp:
- 2018-01-02T00:56:36+01:00 (6 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #15709, comment 48
v1 v2 7 7 Before r13191 {{{img}}} was not reassigned, {{{ImageDisplay.this.image = rot;}}} was used right away in this code block. 8 8 9 I changed this to achieve more atomicity in the rotating case, and to use a single assignment to {{{ImageDisplay.this.image}}} only, but overlooked that the MediaTracker would cling on to a ref, if it did not receive a removeImage() instruction.9 I changed this to achieve more atomicity in the rotating case, and to use a single assignment to {{{ImageDisplay.this.image}}}, but overlooked that the MediaTracker would cling on to a ref, if it did not receive a removeImage() instruction. 10 10 11 11 The reason to reassigning {{{img}}} is just imho: If there ever is a need to do more post-processing to {{{img}}} in the future, we now have the modularity to plug in a code section in between the rotating code and the finalizing assignment to {{{ImageDisplay.this.image}}} in this method.