Modify

Opened 2 months ago

Closed 2 weeks ago

Last modified 2 weeks ago

#15664 closed enhancement (fixed)

Drop area=yes from closed highway=services|rest_area

Reported by: naoliv Owned by: team
Priority: normal Milestone: 18.02
Component: Core validator Version:
Keywords: highway area Cc: Klumbumbus

Description

I guess that due to https://github.com/gravitystorm/openstreetmap-carto/issues/137 and https://github.com/openstreetmap/iD/issues/4194 we have 12320 highway=services|rest_area with an unnecessary area=yes https://overpass-turbo.eu/s/tKb

It seems safe to drop area=yes

  • data/validator/unnecessary.mapcss

     
    3232  fixRemove: "{2.key}";
    3333}
    3434
     35/* #15664 */
     36area:closed[highway=rest_area][area?],
     37area:closed[highway=services][area?] {
     38  throwWarning: tr("{0} is unnecessary for {1}", "{2.key}", "{1.tag}");
     39  group: tr("unnecessary tag");
     40  fixRemove: "{2.key}";
     41}
     42
    3543*[emergency=permissive] {
    3644  /* see #9458 - emergency=permissive makes no sense */
    3745  throwWarning: tr("{0} makes no sense", "{0.tag");

Attachments (0)

Change History (7)

comment:1 Changed 2 months ago by Don-vip

Cc: Klumbumbus added
Keywords: highway area added

comment:2 Changed 2 months ago by naoliv

There are:
railway=roundhouse + area=yes has 3 objects
railway=station + area=yes has 3434
railway=traverser + area=yes has 63
railway=turntable + area=yes has 178
railway=wash + area=yes has 5

But it seems that the default renderer still needs area=yes for some cases.
For example, railway=station without area isn't rendered https://www.openstreetmap.org/way/233216247
While with area=yes it is: https://www.openstreetmap.org/way/332922836

comment:3 in reply to:  2 ; Changed 3 weeks ago by Klumbumbus

Replying to naoliv:

For example, railway=station without area isn't rendered https://www.openstreetmap.org/way/233216247

This is rendered!?

comment:4 in reply to:  3 Changed 3 weeks ago by naoliv

Replying to Klumbumbus:

Replying to naoliv:

For example, railway=station without area isn't rendered https://www.openstreetmap.org/way/233216247

This is rendered!?

Maybe it's now rendered because it was modified to include public_transport=station :-)

Some new railway=station examples
https://www.openstreetmap.org/way/93768774
https://www.openstreetmap.org/way/194746272
https://www.openstreetmap.org/way/515564646
https://www.openstreetmap.org/way/310235340

comment:5 Changed 3 weeks ago by Klumbumbus

Hm strange, I thought the public_transport tags were not in the carto database at all.

comment:6 Changed 2 weeks ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 13377/josm:

fix #15664 - warn about unnecessary area=yes at closed highway=services|rest_area

comment:7 Changed 2 weeks ago by Klumbumbus

Milestone: 18.02

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.