Modify

Opened 6 years ago

Closed 6 years ago

#15613 closed enhancement (fixed)

add direction help image to viewpoint preset

Reported by: Klumbumbus Owned by: Klumbumbus
Priority: normal Milestone: 17.12
Component: Internal preset Version:
Keywords: Cc:

Description

I recently added the direction key to my known viewpoints and I found it very useful to have the help image from osmwiki:Key:direction directly in the preset. I even used a plastic ruler on my screen to compare the help image with the aerial imagery :D

Any objections to add it to the default preset?


Attachments (1)

viewpoint_preset.png (22.5 KB ) - added by Klumbumbus 6 years ago.

Download all attachments as: .zip

Change History (5)

by Klumbumbus, 6 years ago

Attachment: viewpoint_preset.png added

comment:1 by Don-vip, 6 years ago

What does the patch look like?

comment:2 by Klumbumbus, 6 years ago

  • data/defaultpresets.xml

     
    43614361            <key key="tourism" value="viewpoint" />
    43624362            <text key="name" text="Name" />
    43634363            <combo key="direction" text="Direction" delimiter="|" values="N|E|S|W|NE|NNE-S|180|90-270|270-90|0-360|70-110;250-290" values_no_i18n="true" values_sort="false" />
     4364            <space />
     4365            <label text="" icon="https://wiki.openstreetmap.org/w/images/e/e0/Angles.svg" icon_size="231" />
    43644366            <!--<check key="man_made" value="tower" text="Look-Out Tower" />-->
    43654367        </item> <!-- Viewpoint -->
    43664368        <separator/>

(icon path must be adjusted when icon is copied in our images folder.)

comment:3 by Don-vip, 6 years ago

OK, no objection if the file is shipped with JOSM.

comment:4 by Klumbumbus, 6 years ago

Resolution: fixed
Status: assignedclosed

In 13183/josm:

fix #15613, see #14989 - add direction help image to viewpoint preset (icon from https://wiki.openstreetmap.org/wiki/File:Angles.svg, PD licensed)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Klumbumbus.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.