Modify

Opened 4 weeks ago

Closed 3 weeks ago

#15580 closed defect (fixed)

Validator warns about overlapping ways for abandoned:buildings [patch]

Reported by: anonymous Owned by: team
Priority: minor Milestone: 17.11
Component: Core validator Version:
Keywords: Cc:

Description (last modified by Klumbumbus)

How to reproduce:
After mapping connected buildings and running the validator without warnings, change the "building:yes" tag to "abandoned:building:yes" tag. The validator throws warning about overlapping ways. The same logic should apply whether the building is complete or just the walls are there.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2017-11-20 01:25:31 +0100 (Mon, 20 Nov 2017)
Build-Date:2017-11-20 02:32:02
Revision:13136
Relative:URL: ^/trunk

Identification: JOSM/1.5 (13136 en) Windows 10 64-Bit
OS Build number: Windows 10 Enterprise 1607 (14393)
Memory Usage: 504 MB / 989 MB (204 MB allocated, but free)
Java version: 1.8.0_121-b13, Oracle Corporation, Java HotSpot(TM) Client VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080
VM arguments: [-Djosm.home=./, -Djosm.pref=./_HOT]
Dataset consistency test: No problems found

Attachments (1)

Buildings_example.osm (21.2 KB) - added by anonymous 3 weeks ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 4 weeks ago by Klumbumbus

Component: CoreCore validator
Description: modified (diff)

Please attach a sample osm file which can be used to reproduce the warning.

comment:2 Changed 4 weeks ago by Klumbumbus

Owner: changed from team to anonymous
Status: newneedinfo

Changed 3 weeks ago by anonymous

Attachment: Buildings_example.osm added

comment:3 Changed 3 weeks ago by anonymous

Sorry, I am somewhat fighting with the system and so the file is added separately.

I have added the example osm file with two connected buildings. It is currently tagged as building=yes, the validator doesn't complain.
Change to abandoned:building=yes (valid tagging with lifecycle prefix), and the validator message comes up.

comment:4 Changed 3 weeks ago by Klumbumbus

Owner: changed from anonymous to team
Status: needinfonew

Ok, now I understand, you need to change the tags on both building. I tried it only with changing one building.

comment:5 Changed 3 weeks ago by Klumbumbus

Milestone: 17.11
Summary: Validator warns about overlapping ways for abandoned:buildingsValidator warns about overlapping ways for abandoned:buildings [patch]

Patch. However I'm sure this produces an checkstyle warning and I don't know exactly where and how to split the long line, so please fix it before commiting :)

  • OverlappingWays.java

     
    5050    protected static final int DUPLICATE_WAY_SEGMENT = 121;
    5151
    5252    protected static final ListProperty IGNORED_KEYS = new ListProperty(
    53             "overlapping-ways.ignored-keys", Arrays.asList("barrier", "building", "historic:building", "man_made"));
     53            "overlapping-ways.ignored-keys", Arrays.asList("barrier", "building", "historic:building", "demolished:building", "removed:building", "disused:building", "abandoned:building", "proposed:building", "man_made"));
    5454
    5555    /** Constructor */
    5656    public OverlappingWays() {

comment:6 Changed 3 weeks ago by Don-vip

Resolution: fixed
Status: newclosed

In 13153/josm:

fix #15580 - Validator warns about overlapping ways for abandoned:buildings (patch by Klumbumbus)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.