Opened 6 years ago
Closed 6 years ago
#15513 closed enhancement (duplicate)
Allow the upload task to run in background
Reported by: | udit | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Core | Version: | |
Keywords: | upload | Cc: | naoliv |
Description
Currently the upload from JOSM happens using the UploadPrimitivesTask class. The progress monitor for this upload runs on the EDT hence the app locks up for the entire duration of upload. I presume this is by design but for slow internet connections and large changesets this upload time becomes really large. Is there a safe way to make the upload run in background?
Can we discuss some approach that might be able to fix this here?
Attachments (0)
Change History (3)
comment:1 by , 6 years ago
Keywords: | upload added |
---|
comment:2 by , 6 years ago
Cc: | added |
---|
comment:3 by , 6 years ago
Resolution: | → duplicate |
---|---|
Status: | new → closed |
Closed as duplicate of #8509.
The layer and dataset is editable during the upload task. A reason for that is the post upload cleanups - Remove deleted primitives, Mark updated primitives as not-modified etc.
What if we defensively copy the layer and dataset and upload these in the background. In the meanwhile the user can be given a fresh layer to work on. Once the upload happens successfully the uploaded data can be merged into this newly created layer.
However in case of conflicts we would have to switch back to the original layer for conflict resolution. What are the other ways in which it can fail?
I have created a patch for similar changes which work for the happy path. I am not so sure on how to check the changes against failures.