Modify

Opened 4 weeks ago

Closed 2 weeks ago

#15478 closed enhancement (fixed)

[PATCH] Warn about unconnected highway=milestone

Reported by: naoliv Owned by: team
Priority: normal Milestone: 17.11
Component: Core validator Version:
Keywords: Cc:

Description

https://wiki.openstreetmap.org/wiki/Tag:highway=milestone says that the node should be part of the way that represents the highway.

Patch bellow adds a test for unconnected highway=milestone:

  • data/validator/geometry.mapcss

     
    216216node:unconnected:in-downloaded-area[highway=give_way],
    217217node:unconnected:in-downloaded-area[highway=traffic_signals],
    218218node:unconnected:in-downloaded-area[highway=crossing],
     219node:unconnected:in-downloaded-area[highway=milestone],
    219220node:unconnected:in-downloaded-area[crossing],
    220221node:unconnected:in-downloaded-area[railway=crossing],
    221222node:unconnected:in-downloaded-area[railway=level_crossing],

(a more complete test would be if the node is connected to a highway=*)

Attachments (0)

Change History (4)

comment:1 Changed 4 weeks ago by Klumbumbus

Hm. without reading the wiki page intuitively I would have placed the node at the milstones real position similar to traffic signs. There is a comment on the discussion page too https://wiki.openstreetmap.org/wiki/Talk:Tag:highway%3Dmilestone#Node_on_the_way_or_in_the_mark_position.3F

comment:2 Changed 4 weeks ago by naoliv

If we don't use the node connected to the highway and if we have two or more nearby highways, then we won't be able tell which highway it belongs to; https://wiki.openstreetmap.org/wiki/Key:traffic_sign#As_a_separate_node also says:

it is impossible to reliably deduce the affected road or travel direction in this case

From what I see it makes more sense to have it connected to the highway.

comment:3 Changed 3 weeks ago by Klumbumbus

Milestone: 17.11

comment:4 Changed 2 weeks ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 13074/josm:

fix #15478 - Warn about unconnected highway=milestone and railway=milestone (patch by naoliv)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.