Modify

Opened 4 weeks ago

Closed 2 weeks ago

#15477 closed enhancement (fixed)

Suggest to simplify payment:coins + payment:notes to payment:cash

Reported by: naoliv Owned by: team
Priority: normal Milestone: 17.11
Component: Core validator Version:
Keywords: Cc:

Description

We have 14199 objects with both payment:coins=yes + payment:notes=yes or payment:coins=no + payment:notes=no
http://overpass-turbo.eu/s/szP

And the wiki says that payment:cash=* [is] a shortcut tag for payment:coins=* + payment:notes=*

Should JOSM suggest to simplify payment:coins + payment:notes to payment:cash only?

JOSM:

Build-Date:2017-10-24 09:00:44
Revision:13034
Is-Local-Build:true

Identification: JOSM/1.5 (13034 SVN pt_BR) Linux Debian GNU/Linux testing (buster)
Memory Usage: 3056 MB / 6372 MB (1955 MB allocated, but free)
Java version: 1.8.0_144-8u144-b01-1-b01, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1600x900, :0.1 1280x1024
Maximum Screen Size: 1600x1024
Java package: openjdk-8-jre:amd64-8u144-b01-1
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-13
VM arguments: [-Dawt.useSystemAAFontSettings=on]
Dataset consistency test: No problems found

Plugins:
+ Create_grid_of_ways (32699)
+ FastDraw (33583)
+ ImportImagePlugin (33563)
+ OpeningHoursEditor (33185)
+ PicLayer (33385)
+ RoadSigns (33579)
+ SimplifyArea (33004)
+ apache-commons (33668)
+ buildings_tools (33004)
+ conflation (0.5.5)
+ contourmerge (1032)
+ download_along (33710)
+ editgpx (33004)
+ ejml (32680)
+ geojson (66)
+ geotools (33380)
+ importvec (33564)
+ indoorhelper (33632)
+ jts (32699)
+ log4j (32699)
+ measurement (33088)
+ merge-overlap (33436)
+ opendata (33617)
+ pbf (33568)
+ pdfimport (33579)
+ poly (33570)
+ reverter (33572)
+ scripting (30775)
+ tageditor (33579)
+ todo (30303)
+ turnlanes (33294)
+ turnlanes-tagging (254)
+ turnrestrictions (33537)
+ undelete (33480)
+ utilsplugin2 (33704)

Attachments (0)

Change History (4)

comment:1 Changed 4 weeks ago by Klumbumbus

I'm not sure if payment:coins=yes + payment:notes=yes is more accurate (both checked) than just payment:cash=yes, which could mean unknown if both is accepted. Changing it to payment:cash=yes only would lead to information loss in this case.

I would rather suggest to remove payment:cash if all three are tagged together at one object.

More opinions?

comment:2 in reply to:  1 Changed 3 weeks ago by Don-vip

Replying to Klumbumbus:

I would rather suggest to remove payment:cash if all three are tagged together at one object.

More opinions?

+1

comment:3 Changed 3 weeks ago by Klumbumbus

Milestone: 17.11

comment:4 Changed 2 weeks ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 13075/josm:

fix #15477 - suggest to remove payment:cash if tagged together with payment:coins and payment:notes at one object

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.