Modify

Opened 4 weeks ago

Closed 2 weeks ago

Last modified 2 weeks ago

#15469 closed enhancement (fixed)

[Patch] Improve presets for campsites

Reported by: giggls Owned by: team
Priority: normal Milestone: 17.11
Component: Internal preset Version:
Keywords: tourism camp site Cc: Klumbumbus

Description

A few important tags (IMO) are missing from josm campsite presets.

Attached is a patch which improves this situation.

Attachments (1)

campsite-presets.diff (1.4 KB) - added by giggls 4 weeks ago.
patch with enhanced presets

Download all attachments as: .zip

Change History (11)

Changed 4 weeks ago by giggls

Attachment: campsite-presets.diff added

patch with enhanced presets

comment:1 Changed 4 weeks ago by Don-vip

Cc: Klumbumbus added
Component: CoreInternal preset
Keywords: tourism camp site added
Summary: Improve presets for campsites[Patch] Improve presets for campsites

comment:2 Changed 4 weeks ago by hjart

There are lots of camp sites where motor vehicles are not allowed (such as https://www.openstreetmap.org/way/528653026). Could a motor_vehicle=yes/no be included with this please?

comment:3 Changed 4 weeks ago by anonymous

Probably a good idea so just insert this after key="group_only":

<combo key="motor_vehicle" text="Motor vehicle access" values="yes,no" />

comment:4 Changed 3 weeks ago by Klumbumbus

Milestone: 17.11

comment:5 Changed 3 weeks ago by Klumbumbus

The camp_site tag is complicated. The wiki defines the 4 values you added in the patch (basic,standard,serviced,deluxe) and defines it as a subkey to tourism=camp_site, which should be used on the tourism=camp_site object. However looking at taginfo and some examples it seems the mappers use this totally different.
They use it to:

  • map separated pitches within a camp site (camp_site=camp_pitch|pitch|lot)example
  • map other special features within a camp site (camp_site=reception)
  • map places, which are no real camp sites, but only very small places to place a tent (without the tourism=camp_site tag) example

comment:6 Changed 3 weeks ago by giggls

You have a point that camp_site is used in a simular manner as say golf http://wiki.openstreetmap.org/wiki/Key:golf

Nevertheless a classification is needed IMO and I do not see why camp_site as a tag can not act as both, a subkey for tourism=camp_site and a feature tag for camp_site objects.

comment:7 in reply to:  6 Changed 3 weeks ago by Klumbumbus

Replying to giggls:

I do not see why camp_site as a tag can not act as both, a subkey for tourism=camp_site and a feature tag for camp_site objects.

That's not a good idea to use the same key for two different schemas on the same subject.

comment:8 in reply to:  5 Changed 3 weeks ago by hjart

Replying to Klumbumbus:

  • map places, which are no real camp sites, but only very small places to place a tent (without the tourism=camp_site tag) example

Lots of these "very small places to place a tent" are mapped using the tourism=camp_site tag (see the example I gave in my previous comment in this thread). I too would have preferred a different primary tag for them, because lots of less experienced mappers doesn't add subkeys (like backcountry=yes or motor_vehicle=no) to help differentiating them from the larger versions, but considering the situation one of my current projects is going through all tourism=camp_site in Denmark and simply add motor_vehicle=* to all of them

comment:9 Changed 2 weeks ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 13085/josm:

fix #15469 - Improve Campsite preset

comment:10 Changed 2 weeks ago by Klumbumbus

I omitted camp_site=* for now. The situation should be discussed in the forum / an the tagging mailing list before.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.