Modify

Opened 7 years ago

Closed 7 years ago

#15456 closed defect (worksforme)

Conflict of styles setting::partial_fill

Reported by: mpasha Owned by: team
Priority: normal Milestone:
Component: Core mappaint Version: latest
Keywords: template_report Cc:

Description

If the first style is setting::partial_fill true, and in the second active setting (last) setting::partial_fill false, it generally returns true. But in the order of the activity of styles, if false is specified in the latter, then in general also it should be false, despite what is indicated in the previous active styles.
That is now only affects 'true' in the last style, but you need to be in priority and 'false' in the last active style.

P.S .: setting 'true' or 'false' was done in the context menu of the style.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2017-10-18 21:01:45 +0200 (Wed, 18 Oct 2017)
Build-Date:2017-10-19 01:32:09
Revision:13025
Relative:URL: ^/trunk

Identification: JOSM/1.5 (13025 ru) Windows 10 64-Bit
OS Build number: Windows 10 Enterprise 2016 LTSB 1607 (14393)
Memory Usage: 366 MB / 989 MB (41 MB allocated, but free)
Java version: 1.8.0_131-b11, Oracle Corporation, Java HotSpot(TM) Client VM
Screen: \Display0 1366x768
Maximum Screen Size: 1366x768
VM arguments: [-Djosm.home=<josm.pref>]
Dataset consistency test: No problems found

Plugins:
+ BuildingGeneralization (16)
+ CADTools (1007)
+ DirectDownload (33160)
+ FastDraw (33583)
+ FixAddresses (33718)
+ HouseNumberTaggingTool (33714)
+ ImproveWay (12)
+ Mapillary (v1.5.7)
+ OpeningHoursEditor (33185)
+ ShapeTools (1220)
+ alignways (33182)
+ apache-commons (33668)
+ apache-http (32699)
+ buildings_tools (33004)
+ continuosDownload (64)
+ contourmerge (1032)
+ download_along (33710)
+ editgpx (33004)
+ ejml (32680)
+ geotools (33380)
+ imagery_offset_db (33547)
+ jogl (1.1.0)
+ jts (32699)
+ log4j (32699)
+ merge-overlap (33436)
+ namemanager (33306)
+ reltoolbox (33708)
+ reverter (33572)
+ tag2link (33382)
+ tageditor (33579)
+ terracer (33608)
+ todo (30303)
+ tofix (1505422613)
+ utilsplugin2 (33704)

Tagging presets:
+ https://raw.githubusercontent.com/ruosm-presets/literan-moscow/master/russian_shops.xml

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://github.com/igitov/forest-josm-style/archive/master.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/NewHighwayColors&zip=1
- <josm.pref>\styles\indoor.mapcss
- D:\Programs\JOSM_Portable\Map Styles\elemstyles1.mapcss
+ D:\Programs\JOSM_Portable\Map Styles\New.mapcss
- D:\Programs\JOSM_Portable\Map Styles\Ones test.mapcss
- http://mijndev.openstreetmap.nl/~allroads/JOSM/Styles/Road_Extended_JOSM_style.zip
- %UserProfile%\Downloads\Road_Extended_JOSM_style\Road_Extended_JOSM_style.mapcss
- D:\Programs\JOSM_Portable\Map Styles\Test\potlatch2.mapcss
- D:\Programs\JOSM_Portable\Map Styles\Test\lane and road attributes.mapcss
- D:\Programs\JOSM_Portable\Map Styles\Test\Лес тест.mapcss

Validator rules:
+ <josm.pref>\validator\indoorhelper.validator.mapcss

Last errors/warnings:
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- E: java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in escape (%) pattern - For input string: " п"
- E: java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in escape (%) pattern - For input string: " п"
- E: java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in escape (%) pattern - For input string: " п"
- E: java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in escape (%) pattern - For input string: " п"
- E: java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in escape (%) pattern - For input string: " п"
- E: java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in escape (%) pattern - For input string: " п"
- E: Не удалось найти изображение «other/icon.svg»
- W: Mappaint style "standard" (Лес) icon "other/icon.svg" not found.

Attachments (0)

Change History (4)

comment:1 by Don-vip, 7 years ago

Milestone: 17.10

please don't set milestone yourself.

comment:2 by bastiK, 7 years ago

Settings should be separate for each style, even if they are named the same. There is no setting inheritance across different styles. What is your setup and what are you trying to achieve overall?

comment:3 by mpasha, 7 years ago

That now I noticed, then the affirmative values of the parameters in the following style replaces the previous ones. And it's great, because you do not need to rewrite the whole style, or you can just change it a little by putting another style on top. My goal is to support the values of false in the drawing styles so that they overlap the values of the same parameter in the previous style.

comment:4 by bastiK, 7 years ago

Resolution: worksforme
Status: newclosed

What you can do is override the effect of the setting, i.e. set fill-extent for all areas in the subsequent style. Other than that, I think it is correct that settings are private to each style.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.