Modify

Opened 8 weeks ago

Closed 8 weeks ago

#15446 closed defect (fixed)

IllegalArgumentException with negative dashes-offset

Reported by: mpasha Owned by: team
Priority: normal Milestone: 17.10
Component: Core mappaint Version: latest
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

1.It appeared when adding maps to the style "dashes-offset: -5" and saving changes later.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2017-10-16 23:15:27 +0200 (Mon, 16 Oct 2017)
Build-Date:2017-10-17 02:09:24
Revision:13009
Relative:URL: ^/trunk

Identification: JOSM/1.5 (13009 ru) Windows 10 64-Bit
OS Build number: Windows 10 Enterprise 2016 LTSB 1607 (14393)
Memory Usage: 465 MB / 989 MB (228 MB allocated, but free)
Java version: 1.8.0_131-b11, Oracle Corporation, Java HotSpot(TM) Client VM
Screen: \Display0 1366x768
Maximum Screen Size: 1366x768
VM arguments: [-Djosm.home=<josm.pref>]
Dataset consistency test: No problems found

Plugins:
+ BuildingGeneralization (16)
+ CADTools (1007)
+ DirectDownload (33160)
+ FastDraw (33583)
+ FixAddresses (33718)
+ HouseNumberTaggingTool (33714)
+ ImproveWay (12)
+ Mapillary (v1.5.7)
+ OpeningHoursEditor (33185)
+ ShapeTools (1220)
+ alignways (33182)
+ apache-commons (33668)
+ apache-http (32699)
+ buildings_tools (33004)
+ continuosDownload (64)
+ contourmerge (1032)
+ download_along (33710)
+ editgpx (33004)
+ ejml (32680)
+ geotools (33380)
+ imagery_offset_db (33547)
+ jogl (1.1.0)
+ jts (32699)
+ log4j (32699)
+ merge-overlap (33436)
+ namemanager (33306)
+ reltoolbox (33708)
+ reverter (33572)
+ tag2link (33382)
+ tageditor (33579)
+ terracer (33608)
+ todo (30303)
+ tofix (1505422613)
+ utilsplugin2 (33704)

Tagging presets:
+ https://raw.githubusercontent.com/ruosm-presets/literan-moscow/master/russian_shops.xml

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://github.com/igitov/forest-josm-style/archive/master.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/NewHighwayColors&zip=1
- <josm.pref>\styles\indoor.mapcss
+ D:\Programs\JOSM_Portable\Map Styles\New.mapcss
- D:\Programs\JOSM_Portable\Map Styles\Ones test.mapcss
- http://mijndev.openstreetmap.nl/~allroads/JOSM/Styles/Road_Extended_JOSM_style.zip
- %UserProfile%\Downloads\Road_Extended_JOSM_style\Road_Extended_JOSM_style.mapcss
- D:\Programs\JOSM_Portable\Map Styles\Test\potlatch2.mapcss
- D:\Programs\JOSM_Portable\Map Styles\elemstyles1.mapcss
- D:\Programs\JOSM_Portable\Map Styles\Test\lane and road attributes.mapcss

Validator rules:
+ <josm.pref>\validator\indoorhelper.validator.mapcss

Last errors/warnings:
- W: Unable to convert property z-index to type class java.lang.Float: found 7 color: #836D30 of type class java.lang.String!
- W: Unable to convert property z-index to type class java.lang.Float: found 7 color: #836D30 of type class java.lang.String!
- W: Unable to convert property z-index to type class java.lang.Float: found 8 color: #836D30 of type class java.lang.String!
- W: Unable to convert property z-index to type class java.lang.Float: found 9 color: #836D30 of type class java.lang.String!
- W: Unable to convert property z-index to type class java.lang.Float: found 1 color: #836D30 of type class java.lang.String!
- W: Unable to convert property major-z-index to type class java.lang.Float: found 1 color: #836D30 of type class java.lang.String!
- W: Unable to convert property major-z-index to type class java.lang.Float: found 8 color: #836D30 of type class java.lang.String!
- W: Unable to convert property major-z-index to type class java.lang.Float: found +8 color: #836D30 of type class java.lang.String!
- W: Unable to convert property major-z-index to type class java.lang.Float: found -8 color: #836D30 of type class java.lang.String!
- E: Handled by bug report queue: java.lang.IllegalArgumentException: negative dash phase


=== REPORTED CRASH DATA ===
ComputeStyleListWorker#acceptDrawable:
 - osm: {Way id=-67887 version=0 MVT nodes=[{Node id=-67888 version=0 MV lat=49.509550246248224,lon=29.93479906976223}, {Node id=-67889 version=0 MV lat=49.508425149746415,lon=29.934804434180265}]}

BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: styled-map-renderer-808 (2268) of main
java.lang.IllegalArgumentException: negative dash phase
	at java.awt.BasicStroke.<init>(BasicStroke.java:208)
	at org.openstreetmap.josm.gui.mappaint.styleelement.LineElement.createImpl(LineElement.java:404)
	at org.openstreetmap.josm.gui.mappaint.styleelement.LineElement.createLine(LineElement.java:271)
	at org.openstreetmap.josm.gui.mappaint.ElemStyles.generateStyles(ElemStyles.java:377)
	at org.openstreetmap.josm.gui.mappaint.ElemStyles.getImpl(ElemStyles.java:229)
	at org.openstreetmap.josm.gui.mappaint.ElemStyles.getStyleCacheWithRange(ElemStyles.java:147)
	at org.openstreetmap.josm.gui.mappaint.ElemStyles.get(ElemStyles.java:126)
	at org.openstreetmap.josm.data.osm.visitor.paint.ComputeStyleListWorker.add(ComputeStyleListWorker.java:164)
	at org.openstreetmap.josm.data.osm.visitor.paint.ComputeStyleListWorker.visit(ComputeStyleListWorker.java:138)
	at org.openstreetmap.josm.data.osm.Way.accept(Way.java:218)
	at org.openstreetmap.josm.data.osm.visitor.paint.ComputeStyleListWorker.acceptDrawable(ComputeStyleListWorker.java:124)
	at org.openstreetmap.josm.data.osm.visitor.paint.ComputeStyleListWorker.computeDirectly(ComputeStyleListWorker.java:111)
	at org.openstreetmap.josm.data.osm.visitor.paint.ComputeStyleListWorker.compute(ComputeStyleListWorker.java:88)
	at org.openstreetmap.josm.data.osm.visitor.paint.ComputeStyleListWorker.compute(ComputeStyleListWorker.java:34)
	at java.util.concurrent.RecursiveTask.exec(RecursiveTask.java:94)
	at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
	at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
	at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
	at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157)

Attachments (0)

Change History (3)

comment:1 Changed 8 weeks ago by Klumbumbus

The value of dashes-offset must be a number ≥0 (see wiki:Help/Styles/MapCSSImplementation)

comment:2 Changed 8 weeks ago by Don-vip

Component: CoreCore mappaint
Summary: Error dashes-offsetIllegalArgumentException with negative dashes-offset

comment:3 Changed 8 weeks ago by Don-vip

Resolution: fixed
Status: newclosed

In 13013/josm:

fix #15446 - robustness against negative dashes-offset

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.