Modify

Opened 3 weeks ago

Closed 3 weeks ago

#15227 closed defect (fixed)

Cannot add a TMS layer with the "transformed image" menu item

Reported by: Zverikk Owned by: team
Priority: normal Milestone: 17.09
Component: Core imagery Version: latest
Keywords: template_report tms Cc:

Description

These days people publish their transformed imagery via OpenAerialMap project. It provides only TMS links, but JOSM requires these to be added the long way, via settings etc. Could you please support temporary TMS layers in "Add transformed imagery" dialog?

What steps will reproduce the problem?

  1. Open JOSM and add some data
  2. Layers Menu → Add a transformed image
  3. Paste a TMS URL

What is the expected result?

TMS layer added

What happens instead?

An exception.

Please provide any additional information below. Attach a screenshot if possible.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2017-09-01 23:55:45 +0200 (Fri, 01 Sep 2017)
Build-Date:2017-09-01 21:58:49
Revision:12711
Relative:URL: ^/trunk

Identification: JOSM/1.5 (12711 ru) Mac OS X 10.11.6
OS Build number: Mac OS X 10.11.6 (15G1421)
Memory Usage: 507 MB / 910 MB (206 MB allocated, but free)
Java version: 1.8.0_91-b14, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: Display 69731266 1440x900
Maximum Screen Size: 1440x900
VM arguments: [-Djava.library.path=/Applications/JOSM.app/Contents/MacOS, -DLibraryDirectory=${HOME}/Library, -DDocumentsDirectory=${HOME}/Documents, -DApplicationSupportDirectory=${HOME}/Library/Application Support, -DCachesDirectory=${HOME}/Library/Caches, -DSandboxEnabled=false, -Dapple.laf.useScreenMenuBar=true, -Dcom.apple.macos.use-file-dialog-packages=true, -Dcom.apple.macos.useScreenMenuBar=true, -Dcom.apple.mrj.application.apple.menu.about.name=JOSM, -Dcom.apple.smallTabs=true]
Dataset consistency test: No problems found

Plugins:
+ FastDraw (33583)
+ Mapillary (v1.5.7)
+ OpeningHoursEditor (33185)
+ PicLayer (33385)
+ apache-commons (33517)
+ apache-http (32699)
+ buildings_tools (33004)
+ ejml (32680)
+ geochat (33545)
+ geotools (33380)
+ imagery_offset_db (33547)
+ jts (32699)
+ log4j (32699)
+ measurement (33088)
+ opendata (33553)
+ pbf (33568)
+ poly (33570)
+ reltoolbox (33530)
+ reverter (33572)
+ turnrestrictions (33537)
+ utilsplugin2 (33579)
+ wikipedia (33541)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1

Last errors/warnings:
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- E: Handled by bug report queue: java.lang.IllegalArgumentException: {z} — неправильный аргумент WMS. Проверьте URL этого сервера:


=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (18) of main
java.lang.IllegalArgumentException: {z} — неправильный аргумент WMS. Проверьте URL этого сервера:
https://tiles.openaerialmap.org/599be11ea260c700113db28e/0/cdcc6e5c-a1f4-496b-9896-a5466dbe2811/{z}/{x}/{y}.png
	at org.openstreetmap.josm.data.imagery.TemplatedWMSTileSource.checkUrl(TemplatedWMSTileSource.java:187)
	at org.openstreetmap.josm.gui.layer.WMSLayer.<init>(WMSLayer.java:67)
	at org.openstreetmap.josm.actions.MapRectifierWMSmenuAction.addWMSLayer(MapRectifierWMSmenuAction.java:249)
	at org.openstreetmap.josm.actions.MapRectifierWMSmenuAction.actionPerformed(MapRectifierWMSmenuAction.java:194)
	at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2022)
	at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2348)
	at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:402)
	at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259)
	at javax.swing.AbstractButton.doClick(AbstractButton.java:376)
	at com.apple.laf.ScreenMenuItem.actionPerformed(ScreenMenuItem.java:125)
	at java.awt.MenuItem.processActionEvent(MenuItem.java:669)
	at java.awt.MenuItem.processEvent(MenuItem.java:628)
	at java.awt.MenuComponent.dispatchEventImpl(MenuComponent.java:351)
	at java.awt.MenuComponent.dispatchEvent(MenuComponent.java:339)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:761)
	at java.awt.EventQueue.access$500(EventQueue.java:97)
	at java.awt.EventQueue$3.run(EventQueue.java:709)
	at java.awt.EventQueue$3.run(EventQueue.java:703)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
	at java.awt.EventQueue$4.run(EventQueue.java:731)
	at java.awt.EventQueue$4.run(EventQueue.java:729)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:728)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

Attachments (0)

Change History (2)

comment:1 Changed 3 weeks ago by Don-vip

Keywords: tms added
Milestone: 17.09

comment:2 Changed 3 weeks ago by Don-vip

Resolution: fixed
Status: newclosed

In 12716/josm:

fix #15227 - call generic imagery layer factory instead of WMSLayer constructor

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.