Modify

Opened 4 months ago

Closed 3 months ago

#15226 closed enhancement (fixed)

[PATCH] support for compiling without JavaFX

Reported by: ris Owned by: Don-vip
Priority: normal Milestone: 17.09
Component: Core Version: latest
Keywords: build ant javafx optional Cc:

Description

Some platforms don't always have JavaFX available (e.g. it doesn't come by default with openjdk 8 on linux) and some of us want to be able to develop from these platforms.

This is the patch that I'm using (against 12711 I think?) to allow me to do so.

Reasons people may not like it: ruins compile-time exception checking for the JavaFxMediaPlayer constructor call.

I'd appreciate it if someone could test this on a JavaFX platform as I don't *actually have* a JavaFX-enabled build platform available to me right now...

Attachments (1)

josm-r12711-build-without-javafx.patch (2.0 KB) - added by ris 4 months ago.

Download all attachments as: .zip

Change History (12)

Changed 4 months ago by ris

comment:1 Changed 4 months ago by bastiK

What is your OS?

comment:2 Changed 4 months ago by ris

Linux (I'm actually building a Nix toolchain to support my plugin development, hence no openjfx package available)

comment:3 Changed 4 months ago by bastiK

Summary: PATCH: support for compiling without JavaFX[PATCH] support for compiling without JavaFX

comment:4 Changed 4 months ago by bastiK

Patch looks okay to me.

comment:5 Changed 4 months ago by Don-vip

Patch looks ok but efforts should really be made by those Linux distributions which do not provide openjfx. Debian provides it for years!

comment:6 Changed 4 months ago by ris

In a perfect world, yes, and a few NixOS people (myself included) have looked into packaging OpenJFX but it is a serious piece of work with many subtly version-sensitive dependencies which will be tricky to get a reproducible build of.

Last edited 4 months ago by ris (previous) (diff)

comment:7 Changed 4 months ago by Don-vip

Milestone: 17.09
Owner: changed from team to Don-vip
Status: newassigned

comment:8 Changed 4 months ago by Don-vip

Resolution: fixed
Status: assignedclosed

In 12715/josm:

fix #15226 - see #2089 - support for compiling without JavaFX (modified patch by ris)

comment:9 Changed 3 months ago by Don-vip

In 12774/josm:

see #15226 - see #2089 - use "noJavaFx" flag in Dockerfile

comment:10 Changed 3 months ago by ris

Resolution: fixed
Status: closedreopened

It doesn't look like this patch got applied properly. The hunk for build.xml was *supposed* to append

<exclude name="org/openstreetmap/josm/io/audio/JavaFxMediaPlayer.java" if:set="noJavaFX"/>

to the innards of the compile <javac ...> task, but instead got applied to the compile-jmapviewer task, where it makes no sense as no such file exists there.

comment:11 Changed 3 months ago by Don-vip

Resolution: fixed
Status: reopenedclosed

In 12897/josm:

fix #15226 - fix "noJavaFx" flag

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.