Modify

Opened 4 months ago

Closed 4 months ago

Last modified 4 months ago

#15111 closed defect (invalid)

adding wms layer causes crash

Reported by: anonymous Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. imagery -> add layer
  2. https://services.slip.wa.gov.au/public/services/SLIP_Public_Services/Locate/MapServer/WMSServer?LAYERS=1&TRANSPARENT=TRUE&SERVICE=WMS&VERSION=1.1.1&REQUEST=GetMap&STYLES=&FORMAT=png&SRS=EPSG:3857&BBOX={bbox-epsg-3857}&WIDTH=256&HEIGHT=256

What is the expected result?

The base tiles should be placed on the map

What happens instead?

an unexpected exception

Please provide any additional information below. Attach a screenshot if possible.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2017-07-30 17:07:42 +0200 (Sun, 30 Jul 2017)
Build-Date:2017-07-30 15:14:00
Revision:12542
Relative:URL: ^/trunk

Identification: JOSM/1.5 (12542 en) Windows 10 64-Bit
OS Build number: Windows 10 Enterprise 1703 (15063)
Memory Usage: 803 MB / 910 MB (421 MB allocated, but free)
Java version: 1.8.0_91-b14, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1080, \Display1 1680x1050, \Display2 1680x1050
Maximum Screen Size: 1920x1080

Dataset consistency test:
[WARN - NO NODES] Way {Way id=435022374 version=1 VT nodes=[{Node id=4329578774 version=1 V lat=-32.4985577,lon=115.9639427}]} has only one node
[WARN - NO NODES] Way {Way id=49897613 version=7 VT nodes=[{Node id=634145624 version=1 V lat=-32.4970078,lon=115.7729597}]} has only one node
[WARN - NO NODES] Way {Way id=136201726 version=6 VT nodes=[{Node id=1494410698 version=1 V lat=-32.128305,lon=116.2045403}]} has only one node
[WARN - NO NODES] Way {Way id=44168974 version=7 VT nodes=[{Node id=561081695 version=2 V lat=-31.8744995,lon=116.2063342}]} has only one node
[WARN - NO NODES] Way {Way id=25701185 version=8 VT nodes=[{Node id=1879844545 version=2 V lat=-31.7058203,lon=115.8107754}]} has only one node
[WARN - NO NODES] Way {Way id=28475085 version=5 VT nodes=[{Node id=312815215 version=4 V lat=-31.7051112,lon=115.8058271}]} has only one node
[WARN - NO NODES] Way {Way id=176781727 version=1 VT nodes=[{Node id=1872630381 version=1 V lat=-31.7051547,lon=116.0860188}]} has only one node
[WARN - NO NODES] Way {Way id=44169217 version=7 VT nodes=[{Node id=561085505 version=3 V lat=-31.8725728,lon=116.2070058}]} has only one node
[WARN - NO NODES] Way {Way id=206970766 version=1 VT nodes=[{Node id=315524123 version=11 V lat=-31.7052463,lon=115.7772878}]} has only one node
[WARN - NO NODES] Way {Way id=77347986 version=1 VT nodes=[{Node id=910430988 version=1 V lat=-32.4977513,lon=116.1575382}]} has only one node
[WARN - NO NODES] Way {Way id=158407468 version=1 VT nodes=[{Node id=1706041528 version=1 V lat=-31.7807966,lon=116.2078976}]} has only one node
[WARN - NO NODES] Way {Way id=160439328 version=1 VT nodes=[{Node id=567364129 version=1 VT lat=-31.8797528,lon=116.2079798}]} has only one node
[WARN - NO NODES] Way {Way id=348667109 version=2 VT nodes=[{Node id=3547241125 version=1 V lat=-32.4985568,lon=115.9318617}]} has only one node
[WARN - NO NODES] Way {Way id=59591304 version=7 VT nodes=[{Node id=312816428 version=5 V lat=-31.7050455,lon=115.8084535}]} has only one node
[WARN - NO NODES] Way {Way id=161360701 version=1 VT nodes=[{Node id=1733407761 version=1 V lat=-31.8781798,lon=116.2079122}]} has only one node
[WARN - NO NODES] Way {Way id=235150485 version=2 VT nodes=[{Node id=2432348543 version=1 V lat=-31.7067856,lon=115.9483266}]} has only one node
[WARN - NO NODES] Way {Way id=348667105 version=2 VT nodes=[{Node id=3547241118 version=1 V lat=-32.4985582,lon=115.9362463}]} has only one node
[WARN - NO NODES] Way {Way id=28702395 version=6 VT nodes=[{Node id=315522936 version=2 VT lat=-31.7051573,lon=115.7955188}]} has only one node
[WARN - NO NODES] Way {Way id=206970763 version=1 VT nodes=[{Node id=315524074 version=9 V lat=-31.705296,lon=115.7881373}]} has only one node
[WARN - NO NODES] Way {Way id=49897624 version=4 VT nodes=[{Node id=190470710 version=2 V lat=-32.4983103,lon=115.754515}]} has only one node
[WARN - NO NODES] Way {Way id=25701154 version=3 VT nodes=[{Node id=280203818 version=2 VT lat=-31.7052908,lon=115.834548}]} has only one node
[WARN - NO NODES] Way {Way id=179478586 version=1 VT nodes=[{Node id=1898567664 version=1 V lat=-31.705071,lon=116.125585}]} has only one node
[WARN - NO NODES] Way {Way id=176797955 version=1 VT nodes=[{Node id=1872858612 version=1 V lat=-31.7054488,lon=116.0418151}]} has only one node
[WARN - NO NODES] Way {Way id=52336563 version=4 VT nodes=[{Node id=665842146 version=2 V lat=-31.9004845,lon=116.2070837}]} has only one node
[WARN - NO NODES] Way {Way id=195806158 version=2 VT nodes=[{Node id=2062266163 version=1 V lat=-32.4986324,lon=115.8600632}]} has only one node
[WARN - NO NODES] Way {Way id=161360614 version=1 VT nodes=[{Node id=1733406487 version=1 V lat=-31.8732113,lon=116.207954}]} has only one node
[WARN - NO NODES] Way {Way id=177035150 version=1 VT nodes=[{Node id=1875015773 version=1 V lat=-31.7050119,lon=116.0648216}]} has only one node
[WARN - NO NODES] Way {Way id=44168994 version=7 VT nodes=[{Node id=561081933 version=1 V lat=-31.8787183,lon=116.2068901}]} has only one node
[WARN - NO NODES] Way {Way id=158312057 version=1 VT nodes=[{Node id=1705380755 version=1 V lat=-31.837762,lon=116.2078342}]} has only one node
[WARN - NO NODES] Way {Way id=136632976 version=1 VT nodes=[{Node id=1499051746 version=1 V lat=-32.2563795,lon=116.2078811}]} has only one node
[WARN - NO NODES] Way {Way id=137261919 version=1 VT nodes=[{Node id=1503863590 version=1 V lat=-32.2937806,lon=116.2073492}]} has only one node
[WARN - NO NODES] Way {Way id=158921420 version=1 VT> nodes=[{Node id=1710398240 version=1 V lat=-31.7051186,lon=116.207396}]} has only one node


Plugins:
+ turnrestrictions (33088)

Last errors/warnings:
- W: Update plugins - org.openstreetmap.josm.plugins.PluginHandler$UpdatePluginsMessagePanel[,0,0,0x0,invalid,layout=java.awt.GridBagLayout,alignmentX=0.0,alignmentY=0.0,border=,flags=9,maximumSize=,minimumSize=,preferredSize=]
- E: Handled by bug report queue: java.lang.IllegalArgumentException: {bbox-epsg-3857} is not a valid WMS argument. Please check this server URL:


=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (20) of main
java.lang.IllegalArgumentException: {bbox-epsg-3857} is not a valid WMS argument. Please check this server URL:
https://services.slip.wa.gov.au/public/services/SLIP_Public_Services/Locate/MapServer/WMSServer?LAYERS=1&TRANSPARENT=TRUE&SERVICE=WMS&VERSION=1.1.1&REQUEST=GetMap&STYLES=&FORMAT=png&SRS=EPSG:3857&BBOX={bbox-epsg-3857}&WIDTH=256&HEIGHT=256
	at org.openstreetmap.josm.data.imagery.TemplatedWMSTileSource.checkUrl(TemplatedWMSTileSource.java:187)
	at org.openstreetmap.josm.gui.layer.WMSLayer.<init>(WMSLayer.java:66)
	at org.openstreetmap.josm.actions.MapRectifierWMSmenuAction.addWMSLayer(MapRectifierWMSmenuAction.java:247)
	at org.openstreetmap.josm.actions.MapRectifierWMSmenuAction.actionPerformed(MapRectifierWMSmenuAction.java:192)
	at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
	at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
	at javax.swing.AbstractButton.doClick(Unknown Source)
	at javax.swing.plaf.basic.BasicMenuItemUI.doClick(Unknown Source)
	at javax.swing.plaf.basic.BasicMenuItemUI$Handler.mouseReleased(Unknown Source)
	at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source)
	at java.awt.Component.processMouseEvent(Unknown Source)
	at javax.swing.JComponent.processMouseEvent(Unknown Source)
	at java.awt.Component.processEvent(Unknown Source)
	at java.awt.Container.processEvent(Unknown Source)
	at java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Window.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.awt.EventQueue.access$500(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.run(Unknown Source)

Attachments (0)

Change History (4)

comment:1 Changed 4 months ago by stoecker

Resolution: invalid
Status: newclosed

Well, the error is pretty explicit:

java.lang.IllegalArgumentException: {bbox-epsg-3857} is not a valid WMS argument. Please check this server URL

See Maps description for valid arguments.

comment:2 Changed 4 months ago by anonymous

Resolution: invalid
Status: closedreopened

ok thats great, thanks.

Just reopening as it seems pretty terrible user interface design to cause a full software crash from a URL entry.

perhaps a graceful fallback with an error message would be better?

comment:3 Changed 4 months ago by anonymous

Resolution: fixed
Status: reopenedclosed

comment:4 Changed 4 months ago by Don-vip

Resolution: fixedinvalid

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.