Modify

Opened 7 years ago

Closed 7 years ago

#15109 closed defect (fixed)

Mapillary tag added by mapillary-plugin not recognized as change

Reported by: abkuntze@… Owned by: floscher
Priority: normal Milestone:
Component: Plugin mapillary Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. Select a node
  2. Select a mapillary picture
  3. click on "add mapillary tag" in mapillay picture information section
  4. try to upload change

What is the expected result?

tag will be uploaded

What happens instead?

"no change" message

Please provide any additional information below. Attach a screenshot if possible.

If you change the tag manually after adding, it is recognized as change and it works as expected.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2017-07-30 17:07:42 +0200 (Sun, 30 Jul 2017)
Build-Date:2017-07-30 15:14:00
Revision:12542
Relative:URL: ^/trunk

Identification: JOSM/1.5 (12542 de) Linux Ubuntu 16.04.2 LTS
Memory Usage: 1079 MB / 2656 MB (154 MB allocated, but free)
Java version: 1.8.0_131-8u131-b11-2ubuntu1.16.04.2-b11, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1680x1050, :0.1 1680x1050
Maximum Screen Size: 1680x1050
Java package: openjdk-8-jre:amd64-8u131-b11-2ubuntu1.16.04.2
WebStart package: icedtea-netx:amd64-1.6.2-3ubuntu1
VM arguments: [-Dicedtea-web.bin.name=javaws, -Dicedtea-web.bin.location=/usr/bin/javaws, -Djava.security.manager, -Djava.security.policy=/etc/icedtea-web/javaws.policy]
Dataset consistency test: No problems found

Plugins:
+ HouseNumberTaggingTool (33160)
+ ImportImagePlugin (33372)
+ Mapillary (v1.5.5)
+ OpenStreetCam (93)
+ OpeningHoursEditor (33185)
+ RoadSigns (33204)
+ apache-commons (32994)
+ apache-http (32699)
+ buildings_tools (33004)
+ continuosDownload (53)
+ contourmerge (1030)
+ ejml (32680)
+ geochat (33088)
+ geojson (52)
+ geotools (33380)
+ indoorhelper (33088)
+ jts (32699)
+ log4j (32699)
+ opendata (33438)
+ pbf (33241)
+ pt_assistant (33470)
+ public_transport (33166)
+ public_transport_layer (33447)
+ reverter (33088)
+ tageditor (33021)
+ terracer (33088)
+ turnlanes (33294)
+ turnlanes-tagging (254)
+ turnrestrictions (33088)
+ undelete (33480)
+ utilsplugin2 (33328)
+ wikipedia (33288)

Tagging presets:
+ http://www.openrailwaymap.org/josm-presets/de.zip
+ http://www.openrailwaymap.org/josm-presets/de-signals-eso.zip
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/DE.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/Crafts&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/public_bookcase&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Surveillance&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/OpenStationMap&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Light_sources&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Heritage&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/BicycleJunction&zip=1

Map paint styles:
+ http://www.openrailwaymap.org/styles/josm-additional.zip
- http://www.openrailwaymap.org/styles/electrified.zip
- http://www.openrailwaymap.org/styles/standard.zip
+ http://www.openrailwaymap.org/styles/maxspeed.zip
+ http://www.openrailwaymap.org/styles/signals.zip
- https://raw.githubusercontent.com/species/josm-preset-wheelchair/master/sidewalks_kerbs.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Cycleways&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Osmc&zip=1

Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/GermanySpecific&zip=1
+ http://www.openrailwaymap.org/validator/openrailwaymap.validator.mapcss
+ http://www.openrailwaymap.org/validator/de-openrailwaymap.validator.mapcss

Last errors/warnings:
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet

Attachments (0)

Change History (3)

comment:1 by MKnight, 7 years ago

Can confirm that.

the plugin doesnt sets "action" in the (xml-)data ... so there's no action...

comment:2 by floscher, 7 years ago

Thank you for reporting! I'll look into this soon.

This was also reported as https://github.com/JOSM/Mapillary/issues/61.

comment:3 by floscher, 7 years ago

Resolution: fixed
Status: newclosed

Sorry for the long response time, but finally I managed to look into this issue. It is now fixed with commit e111ae6 and it will roll out with the next release after v1.5.6.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain floscher.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.