Modify

Opened 5 weeks ago

Closed 2 weeks ago

#15035 closed enhancement (fixed)

Suggest to mappers via the UI (or a validator warning) that adding data at (0,0) is probably an error

Reported by: SomeoneElse Owned by: team
Priority: normal Milestone: 17.08
Component: Core validator Version:
Keywords: Cc: Klumbumbus

Description

A recent change in JOSM seems to have made untagged nodes at "null island" (latitude 0, longitude 0) much more likely. http://www.openstreetmap.org/node/4975940278/history is the latest example of this.

Would it be possible to indicate to mappers that they shouldn't do this?

There is one thing around null island - a weather buoy, and it has tags. Anything new added there, especially with no tags, is very likely to be an error.

From trying to talk to the mappers adding these nodes, I've not managed to get a button-by-button "how to reproduce" from them, but it seems to be something like:

o Try and add something
o Decide not to
o End up adding an untagged node at lat 0 long 0.

Attachments (0)

Change History (10)

comment:1 Changed 5 weeks ago by stoecker

Component: CoreCore validator
Milestone: 17.07

comment:2 Changed 4 weeks ago by Don-vip

Summary: Suggest to mappers via the UI (or a validator warning) that adding data at null island is probably an error.Suggest to mappers via the UI (or a validator warning) that adding data at (0,0) is probably an error

comment:3 Changed 4 weeks ago by Don-vip

Cc: Klumbumbus added

I'm working to implement it in MapCSS:

node[at(0.0,0.0)] {
  throwError: tr("bad boy!");
}

Anyone got a better error message? :)

Last edited 4 weeks ago by Don-vip (previous) (diff)

comment:4 Changed 4 weeks ago by Don-vip

In 12514/josm:

see #15035 - add new at(lat,lon) MapCSS selector function

comment:5 in reply to:  3 Changed 3 weeks ago by Klumbumbus

Replying to Don-vip:

Anyone got a better error message? :)

We need to exclude osmwww:node/3815077900

/* #15035 */
node[osm_id()!=3815077900][at(0.0,0.0)] {
  throwError: tr("Object at Position 0.00E 0.00N. There is nothing at this position except an already mapped weather buoy.");
  fixDeleteObject: this;
}

comment:6 Changed 3 weeks ago by Don-vip

The id is not stable, it would be better to allow [man_made=monitoring_station] in case the object is deleted and created again.

comment:7 Changed 3 weeks ago by Klumbumbus

Yes, but I think that if someone deletes it, a power mapper will revert it instead creating a new id. Atleast thats the way it worked for this buoy until now when looking at the history of this node in JOSM. However if we add fixDeleteObject: this; it would be a bit safer to use `[man_made=monitoring_station] in case a new id is created indead.

Version 0, edited 3 weeks ago by Klumbumbus (next)

comment:8 Changed 3 weeks ago by Don-vip

Commit what you think is the best solution :)

comment:9 Changed 3 weeks ago by Klumbumbus

Milestone: 17.0717.08

i18n impact

comment:10 Changed 2 weeks ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 12572/josm:

  • fix #15097 - warn if ferry route way is not properly connected
  • don't warn about bridge and tunnel on ferry routes
  • see #14807 - don't warn about unknown noref=yes
  • fix #15035 - warn for objects at null island (except the weather buoy)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.