Modify

Opened 4 months ago

Closed 5 weeks ago

#15032 closed defect (fixed)

MapCSS classes are not set if defined in information-level rules

Reported by: mkoniecz Owned by: Klumbumbus
Priority: normal Milestone: 17.10
Component: Core validator Version:
Keywords: template_report tourism information guidepost highway Cc: Klumbumbus

Description

What steps will reproduce the problem?

  1. create highway=path/footway
  2. add tourism=information, information=guidepost node on the way
  3. run validator

What is the expected result?

Validator is not complaining, guideposts (especially in mountains) may be placed directly on a path

What happens instead?

Validator complains - tourism node connected to a highway (1)

Please provide any additional information below. Attach a screenshot if possible.

In attachment - one of many potential examples, found via https://duckduckgo.com/?q=drogowskaz+tatry&t=canonical&iax=1&ia=images

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2017-07-07 22:32:46 +0200 (Fri, 07 Jul 2017)
Build-Date:2017-07-08 01:32:27
Revision:12456
Relative:URL: ^/trunk

Identification: JOSM/1.5 (12456 en) Linux Ubuntu 16.04.2 LTS
Memory Usage: 871 MB / 871 MB (395 MB allocated, but free)
Java version: 1.8.0_131-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: :0.0 1920x1080, :0.1 1366x768
Maximum Screen Size: 1920x1080
Dataset consistency test: No problems found

Last errors/warnings:
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out
- W: No default layer selected, choosing first layer.
- W: No default layer selected, choosing first layer.
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out
- W: Already here java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out

Attachments (1)

random_guidepost.jpg (104.3 KB) - added by mkoniecz 4 months ago.

Download all attachments as: .zip

Change History (20)

Changed 4 months ago by mkoniecz

Attachment: random_guidepost.jpg added

comment:1 Changed 4 months ago by mkoniecz

It may be worth checking whatever this warning makes any sense - tourism=attractiom, tourism=alpine_hut also should not raise warnings.

From looking at JOSM values for tourism tag I see not even single value where this warning makes sense.

comment:2 Changed 4 months ago by mkoniecz

To explain: tourism route leading to alpine hut may involve exact mapping of path reaching alpine hut entrance. This is a valid tagging, also if alpine hut is mapped as node.

comment:3 Changed 3 months ago by mkoniecz

@JOSM maintainers

Is it considered as a bug? It should be simple to make a patch but I prefer to check whatever it would be accepted.

comment:4 Changed 7 weeks ago by Don-vip

Cc: Klumbumbus added
Keywords: tourism information guidepost highway added

comment:5 Changed 7 weeks ago by Don-vip

It seems r10037 / r10071 does not work anymore.

comment:6 in reply to:  5 Changed 7 weeks ago by Klumbumbus

Milestone: 17.10

Replying to Don-vip:

It seems r10037 / r10071 does not work anymore.

It works. It reduces the warning for guideposts to info level, which is fine in my eyes as maybe 95% of the guideposts are not in the middle of the way but beside the way. The attched example random_guidepost.jpg is a rather rare case.

For all other tourism nodes I agree that it can make sense to put it directly on the way if the node is the last waynode, i.e. the way ends there.

A tourism=hotel node in the middle of a highway=* should still get a validator message at warning level.

comment:7 Changed 7 weeks ago by mkoniecz

which is fine in my eyes as maybe 95% of the guideposts are not in the middle of the way

It would mean that 5% (10k+*) of guideposts get false positive message. And in how many cases it would be an useful error?

comment:8 Changed 7 weeks ago by Klumbumbus

It is just info level. This means it is just an information, not an error.

I've already corrected a lot of guideposts, which are wrongly tagged on the way. (In some cases these are propably results of unwanted "node snapping" in the editors.) In non alpine areas there are usually no guideposts on the way at all.

comment:9 Changed 7 weeks ago by Don-vip

I got it at warning level during my tests, not info level, I don't understand

comment:10 Changed 7 weeks ago by Klumbumbus

Which tag combination?

comment:11 Changed 7 weeks ago by Don-vip

Summary: tourism node connected to a highway may be a misleading validator complaint for guidepostsMapCSS classes are not set if defined in information-level rules

OK understood. The code behaves as expected only of information level is enabled. Otherwise the rule is not applied, and the MapCSS class not set.

comment:12 Changed 7 weeks ago by Klumbumbus

Oh, you're right. I didn't know that.

comment:13 Changed 7 weeks ago by Don-vip

Me neither, I consider it a bug.

comment:14 Changed 7 weeks ago by Klumbumbus

Well, we could simply split that rule into two, one without error output and one with error output, however we may fall into this trap again some day. Do you plan to fix this in the core?

comment:15 Changed 7 weeks ago by Don-vip

Yes I'm working on a proper fix :)

comment:16 Changed 7 weeks ago by Don-vip

Resolution: fixed
Status: newclosed

In 12948/josm:

fix #15032 - MapCSS classes are not set if defined in information-level rules

comment:17 Changed 7 weeks ago by Klumbumbus

Resolution: fixed
Status: closedreopened

I want to adjust the warning rules for end nodes.

comment:18 Changed 7 weeks ago by Klumbumbus

Owner: changed from team to Klumbumbus
Status: reopenednew

comment:19 Changed 5 weeks ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 13006/josm:

  • fix #15032 - don't warn about tourism nodes on way end nodes
  • see #15401 - adblue is not a fuel, restores sorted fuel list too

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Klumbumbus.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.