Modify

Opened 4 months ago

Closed 4 months ago

#14946 closed defect (fixed)

"Reverse way direction" does not work

Reported by: aceman Owned by: team
Priority: major Milestone: 17.06
Component: Core Version: latest
Keywords: regression Cc: michael2402

Description (last modified by Don-vip)

The command in the Tools menus "Reverse way direction" does not work in latest nightly:

java.lang.IllegalArgumentException: Parameter 'data' must not be null
        at org.openstreetmap.josm.tools.CheckParameterUtil.ensureParameterNotNull(CheckParameterUtil.java:83)
        at org.openstreetmap.josm.command.Command.<init>(Command.java:170)
        at org.openstreetmap.josm.command.ChangeCommand.<init>(ChangeCommand.java:63)
        at org.openstreetmap.josm.corrector.TagCorrector.applyCorrections(TagCorrector.java:177)
        at org.openstreetmap.josm.corrector.ReverseWayTagCorrector.execute(ReverseWayTagCorrector.java:289)
        at org.openstreetmap.josm.actions.ReverseWayAction.reverseWay(ReverseWayAction.java:153)
        at org.openstreetmap.josm.actions.ReverseWayAction.actionPerformed(ReverseWayAction.java:129)
        at javax.swing.SwingUtilities.notifyAction(SwingUtilities.java:1663)
        at javax.swing.JComponent.processKeyBinding(JComponent.java:2882)
        at javax.swing.KeyboardManager.fireBinding(KeyboardManager.java:307)
        at javax.swing.KeyboardManager.fireKeyboardAction(KeyboardManager.java:263)
        at javax.swing.JComponent.processKeyBindingsForAllComponents(JComponent.java:2974)
        at javax.swing.JComponent.processKeyBindings(JComponent.java:2966)
        at javax.swing.JComponent.processKeyEvent(JComponent.java:2845)
        at java.awt.Component.processEvent(Component.java:6310)
        at java.awt.Container.processEvent(Container.java:2236)
        at java.awt.Component.dispatchEventImpl(Component.java:4889)
        at java.awt.Container.dispatchEventImpl(Container.java:2294)
        at java.awt.Component.dispatchEvent(Component.java:4711)
        at java.awt.KeyboardFocusManager.redispatchEvent(KeyboardFocusManager.java:1954)
        at java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(DefaultKeyboardFocusManager.java:806)
        at java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(DefaultKeyboardFocusManager.java:1074)
        at java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(DefaultKeyboardFocusManager.java:945)
        at java.awt.DefaultKeyboardFocusManager.dispatchEvent(DefaultKeyboardFocusManager.java:771)
        at java.awt.Component.dispatchEventImpl(Component.java:4760)
        at java.awt.Container.dispatchEventImpl(Container.java:2294)
        at java.awt.Window.dispatchEventImpl(Window.java:2746)
        at java.awt.Component.dispatchEvent(Component.java:4711)
        at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:758)
        at java.awt.EventQueue.access$500(EventQueue.java:97)
        at java.awt.EventQueue$3.run(EventQueue.java:709)
        at java.awt.EventQueue$3.run(EventQueue.java:703)
        at java.security.AccessController.doPrivileged(Native Method)
        at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
        at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:90)
        at java.awt.EventQueue$4.run(EventQueue.java:731)
        at java.awt.EventQueue$4.run(EventQueue.java:729)
        at java.security.AccessController.doPrivileged(Native Method)
        at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
        at java.awt.EventQueue.dispatchEvent(EventQueue.java:728)
        at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
        at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
        at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
        at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
        at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
        at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

Attachments (0)

Change History (6)

comment:1 Changed 4 months ago by Don-vip

Description: modified (diff)

comment:2 Changed 4 months ago by Don-vip

Keywords: regression added
Milestone: 17.06
Priority: normalmajor

comment:3 Changed 4 months ago by Don-vip

Cc: michael2402 added

comment:4 Changed 4 months ago by Don-vip

regression of r12356

comment:5 Changed 4 months ago by aceman

I tried it on a oneway=-1 street. If you leave the checkbox checked to handle the oneway meaning, it fails. If the checkbox is unchecked, reversing seems to work.

comment:6 Changed 4 months ago by michael2402

Resolution: fixed
Status: newclosed

In 12412/josm:

Fix #14946: Set the right data set for tag corrections when reversing a way.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.