Opened 7 years ago
Closed 7 years ago
#14933 closed enhancement (fixed)
Roundabout splitter
| Reported by: | giackserva | Owned by: | giackserva |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Plugin pt_assistant | Version: | |
| Keywords: | gsoc_pt_assistant roundabout | Cc: |
Description
when a roundabout made of only one way is added to a public transport relation, it seems like the bus is driving all the way around the roundabout instead of just a portion of it. a useful command would perform the following operations on a selected roundabout:
- download bbox to make sure all the ways connecting to the roundabout are present
- find points to split roundabout way(s)
- ask user if it's OK to make roundabout round
- loop over all route relations and repair them
Attachments (0)
Change History (7)
comment:1 by , 7 years ago
| Keywords: | roundabout added |
|---|
comment:2 by , 7 years ago
| Type: | defect → enhancement |
|---|
comment:3 by , 7 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:4 by , 7 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Three tests are failing: https://josm.openstreetmap.de/jenkins/job/JOSM-Plugins/898/testReport/
comment:5 by , 7 years ago
Tests succeed when launched locally, sorry I didn't check jenkins.
At first sight, I have no clue why that is happenings.
At second sight I realized the problem is that the layer manager is trying to delete a null layer. The only place where I delete the layer is at the end of the each test, so perhaps the content of the variable layer gets canceled in the meantime.
Still no idea why that doesn't happen locally.
Any suggestions?
comment:6 by , 7 years ago
Should be fixed in [o33412]. The unit tests didn't work for me in my Eclipse.
comment:7 by , 7 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
changeset [o33399][o33402:33404]