Modify

Opened 7 years ago

Closed 7 years ago

#14896 closed defect (fixed)

PicLayer no longer working as expected since last updates of JOSM and/or JAVA and/or Windows 10

Reported by: anonymous Owned by: michael2402
Priority: normal Milestone:
Component: Plugin piclayer Version:
Keywords: template_report layer invalidation regression Cc:

Description

auf Deutsch: (in english see below)
PicLayer - Aurichten des Bildes:
Es war bis vor kurzem noch so, dass man beim Verschieben, Vergrößern, Ausrichten sah man das Ergebnis in Echtzeit.
Jetzt ist es beim Verschieben so, dass man das Ergebnis erst beim Loslassen der Maustaste sieht (ist nicht so tragisch).
Beim Vergrößern, Verkleinern ist es so, dass das Ergebnis beim Loslassen der Maustaste sehr willkürlich ist und man nicht weiß, ob man das Bild (stark) vergrößert oder verkleinert hat und so ist es eine reine Glücksache, bis man endlich ein einigermaßen richtiges Bild hat.
Beim Ausrichten mit den roten und grünen Pfeilen (eigentlich eine sehr gute Sache gegenüber früher) ist es so,
dass man den ersten grünen Pfeil (Standort) noch setzen kann, den zweiten bzw. dritten bekommt man vielleicht nach wildem Drücken der Maustaste irgendwann zu sehen.
Wechselt man nun zum roten Pfeil um die Standorte der Reihe nach richtig zu verschieben, tut sich fast immer gar nichts mehr, gelegentlich ruckelt das Bild noch etwas.

English Version:
It´s no longer to possible to adjust the pic how it was.
In the earlier versions you could move or adjust the pic and you could see the result directly.
Now:
Adjustment: You can see the result only if you release the mouse button
Decrease - Increase of Picture size: If you try to change the size of the picture the result is now not really predictable, you must be lucky.
Adjustment with the red / green arrows: (a very good step forward in opposite to the beginning versions of PicLayer):
The arrows are no longer working. You can only set the first point, and the second / third appears sometimes on not defined places.

Hopefully somebody can fix these bugs.

regard

Bernhard

Attachments (1)

fix-14896.patch (2.5 KB ) - added by michael2402 7 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 by bastiK, 7 years ago

Keywords: layer invalidation added
Milestone: 17.06
Owner: changed from Larry0ua to michael2402

comment:2 by Don-vip, 7 years ago

Is it a core defect, or does the plugin needs to be updated to latest changes?

comment:3 by anonymous, 7 years ago

It may be possible that the removal of isChanged() caused this. I'll be home tomorrow and have a look at it -- michael

in reply to:  2 comment:4 by bastiK, 7 years ago

Replying to Don-vip:

Is it a core defect, or does the plugin needs to be updated to latest changes?

Not sure, but needs to be fixed regardless.

by michael2402, 7 years ago

Attachment: fix-14896.patch added

comment:5 by michael2402, 7 years ago

The piclayer was never cached (like the other backgrund layers). All layers that did not implement isChanged() were not cached previously and repainted on every MapView#repaint.

I don't want to change it back/introduce any workaround hacks because one single non-invalidating background layer breaks the whole layer draw cache in map view for all layers above it, including the data layer.

The solution is simple in most cases: Replace all Main.map.mapView.repaint() by a layer.invalidate().

comment:6 by michael2402, 7 years ago

Keywords: regression added

comment:7 by Don-vip, 7 years ago

Milestone: 17.06
Resolution: fixed
Status: newclosed

Fixed in [o33384:33386].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain michael2402.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.