[PATCH] Add a new preference to remember changeset tags, and include them by default in all changesets

[rorym]

I suggest adding a new preference upload.changeset.tags.additional, a list of Strings, which will be the additional tags that will be added to every changeset by default. This patch enables this feature. It applies clearly on r12285 (current HEAD), and I have tested it when submitting changesets to OSM.org.

There are suggested changeset tags, and this patch makes it easy to "remember" a set of changeset tags by putting them in your preferences. Otherwise you have to enter the changeset tags all the time.

I hope this is merged, but am open to discussion.

src/org/openstreetmap/josm/gui/io/UploadDialog.java

@@ -16 +16 @@
 import java.beans.PropertyChangeEvent;
 import java.beans.PropertyChangeListener;
 import java.lang.Character.UnicodeBlock;
+import java.util.Arrays;
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.Collections;
@@ -269 +270 @@
     /**
      * Sets the tags for this upload based on (later items overwrite earlier ones):
      * <ul>
+     * <li>From the upload.changeset.tags.additional prefence</li>
      * <li>previous "source" and "comment" input</li>
      * <li>the tags set in the dataset (see {@link DataSet#getChangeSetTags()})</li>
      * <li>the tags from the selected open changeset</li>
@@ -280 +282 @@
     public void setChangesetTags(DataSet dataSet) {
         final Map<String, String> tags = new HashMap<>();
 
+        // From preferences
+        // TODO is there a better way to read this, as a Map, rather than List/Collection?
+        Collection<String> tags_from_prefs = Main.pref.getCollection("upload.changeset.tags.additional", Arrays.asList(new String[] {}));
+        for (Iterator<String> iterator = tags_from_prefs.iterator(); iterator.hasNext();) {
+            tags.put(iterator.next(), iterator.next());
+        }
+
         // obtain from previous input
         tags.put("source", getLastChangesetSourceFromHistory());
         tags.put("comment", getLastChangesetCommentFromHistory());

[bastiK]

Rorym, thanks for the patch! I'm not in favor of applying the patch, because it is essential a new feature that is only accessible by Einstein settings. It means we have to maintain non-trivial code that is known to and used by a very small group of people (possibly just you).

Most typical use of advanced preferences is to make a hard-coded value configurable, but your patch does a bit more than that.

[rorym]

Rats! :(

This change was partially motivated by the fact that JOSM doesn't remember changeset tags between changesets. So if you want to add an extra tags you need to do it manually. I would be happy with JOSM remembering the previously entered changeset tags and automatically using them.

The reason I want to do it is to ​put things in the clacks.

[stoecker]

Replying to rorym:

Rats! :(

This change was partially motivated by the fact that JOSM doesn't remember changeset tags between changesets. So if you want to add an extra tags you need to do it manually. I would be happy with JOSM remembering the previously entered changeset tags and automatically using them.

I also see no reason to integrate this. But you can make a plugin for this purpose ;-)

The reason I want to do it is to ​put things in the clacks.

Well, JOSM website does not forget to handle the overhead properly. You are not alone.

[stoecker]

The reason I want to do it is to ​put things in the clacks.

Well, JOSM website does not forget to handle the overhead properly. You are not alone.

BTW: There are people out there, which simply install all available plugins, even a possible pterry.jar :-)

[rorym]

I have made a more general patch in #15464