Modify

Opened 7 months ago

Closed 6 months ago

Last modified 6 months ago

#14854 closed defect (fixed)

DataIntegrityProblemException when backspace is used several times to revert the creation of a closed way

Reported by: anonymous Owned by: michael2402
Priority: major Milestone: 17.06
Component: Core Version:
Keywords: template_report selection multipolygon backspace regression Cc:

Description

What steps will reproduce the problem?

  1. I added point from a water landuse
  2. I deleleted last points because of a doubt with backspace key
  3. error occured deleting last point

What is the expected result?

What happens instead?

Please provide any additional information below. Attach a screenshot if possible.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2017-05-29 00:35:21 +0200 (Mon, 29 May 2017)
Build-Date:2017-05-28 22:37:41
Revision:12271
Relative:URL: ^/trunk

Identification: JOSM/1.5 (12271 fr) Windows 7 64-Bit
OS Build number: Windows 7 Professional null (7601)
Memory Usage: 247 MB / 247 MB (20 MB allocated, but free)
Java version: 1.8.0_131-b11, Oracle Corporation, Java HotSpot(TM) Client VM
Screen: \Display0 1440x900, \Display1 1440x900
Maximum Screen Size: 1440x900
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=%UserProfile%\AppData\LocalLow\Sun\Java\Deployment\cache\6.0\56\1ee8cfb8-442bc65d, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.splashport=60690, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm.jnlp, -Djnlpx.jvm=<java.home>\bin\javaw.exe]
Dataset consistency test: No problems found

Plugins:
+ DirectDownload (33160)
+ HouseNumberTaggingTool (33160)
+ ImportImagePlugin (33028)
+ Mapillary (v1.5.3)
+ OpeningHoursEditor (33185)
+ PicLayer (33148)
+ SeaChart (33222)
+ SeaMapEditor (33054)
+ apache-commons (32994)
+ apache-http (32699)
+ buildings_tools (33004)
+ cadastre-fr (33301)
+ download_along (32946)
+ ejml (32680)
+ fieldpapers (v0.4.1)
+ geotools (33338)
+ importvec (33088)
+ jts (32699)
+ log4j (32699)
+ measurement (33088)
+ osmarender (33004)
+ pdfimport (33004)
+ reverter (33088)
+ utilsplugin2 (33328)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/Diving&zip=1
+ %UserProfile%\Google Drive\SIG\JOSM, pré-réglages\plongée.xml
+ %UserProfile%\Downloads\JOSM Presets\Presets_Camp_site_extends-preset.xml
+ %UserProfile%\Downloads\JOSM Presets\Presets_CampingForOverlanders-preset.xml
+ %UserProfile%\Downloads\JOSM Presets\Presets_LaneAttributes-preset.xml
+ %UserProfile%\Downloads\JOSM Presets\Presets_OpenSeaMap-PresetForSeamarks-preset.xml
+ %UserProfile%\Downloads\JOSM Presets\Presets_Diving-preset.xml

Last errors/warnings:
- E: java.io.FileNotFoundException: %UserProfile%\Downloads\JOSM Presets\Presets_LaneAttributes-preset.xml (Le chemin d’accès spécifié est introuvable)
- E: %UserProfile%\Downloads\JOSM Presets\Presets_LaneAttributes-preset.xml
- E: java.io.FileNotFoundException: %UserProfile%\Downloads\JOSM Presets\Presets_OpenSeaMap-PresetForSeamarks-preset.xml (Le chemin d’accès spécifié est introuvable)
- E: %UserProfile%\Downloads\JOSM Presets\Presets_OpenSeaMap-PresetForSeamarks-preset.xml
- E: java.io.FileNotFoundException: %UserProfile%\Downloads\JOSM Presets\Presets_Diving-preset.xml (Le chemin d’accès spécifié est introuvable)
- E: %UserProfile%\Downloads\JOSM Presets\Presets_Diving-preset.xml
- E: Handled by bug report queue: org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Primitive must be part of the dataset: {Way id=-84305 version=0 MV nodes=[{Node id=-81916 version=0 MV lat=44.27947691322927,lon=4.45759266346693}, {Node id=-84304 version=0 MV lat=44.279229192925385,lon=4.457128641307355}]}
- E: Handled by bug report queue: org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Primitive must be part of the dataset: {Way id=-84305 version=0 MV nodes=[{Node id=-81916 version=0 MV lat=44.27947691322927,lon=4.45759266346693}, {Node id=-84304 version=0 MV lat=44.279229192925385,lon=4.457128641307355}]}
- E: Handled by bug report queue: org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Primitive must be part of the dataset: {Way id=-84305 version=0 MV nodes=[{Node id=-81916 version=0 MV lat=44.27947691322927,lon=4.45759266346693}, {Node id=-84304 version=0 MV lat=44.279229192925385,lon=4.457128641307355}]}
- E: Handled by bug report queue: org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Primitive must be part of the dataset: {Way id=-84305 version=0 MV nodes=[{Node id=-81916 version=0 MV lat=44.27947691322927,lon=4.45759266346693}, {Node id=-84304 version=0 MV lat=44.279229192925385,lon=4.457128641307355}]}


=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-2 (58) of javawsApplicationThreadGroup
org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Primitive must be part of the dataset: {Way id=-84305 version=0 MV nodes=[{Node id=-81916 version=0 MV lat=44.27947691322927,lon=4.45759266346693}, {Node id=-84304 version=0 MV lat=44.279229192925385,lon=4.457128641307355}]}
	at org.openstreetmap.josm.data.osm.OsmPrimitive.checkDataset(OsmPrimitive.java:252)
	at org.openstreetmap.josm.data.osm.OsmPrimitive.getReferrers(OsmPrimitive.java:996)
	at org.openstreetmap.josm.data.osm.OsmPrimitive.getReferrers(OsmPrimitive.java:1021)
	at org.openstreetmap.josm.actions.CreateMultipolygonAction.getSelectedMultipolygonRelation(CreateMultipolygonAction.java:184)
	at org.openstreetmap.josm.actions.CreateMultipolygonAction.getSelectedMultipolygonRelation(CreateMultipolygonAction.java:175)
	at org.openstreetmap.josm.actions.CreateMultipolygonAction.updateEnabledState(CreateMultipolygonAction.java:273)
	at org.openstreetmap.josm.actions.JosmAction$SelectionChangeAdapter.selectionChanged(JosmAction.java:386)
	at org.openstreetmap.josm.data.osm.event.SelectionEventManager$OldListenerInfo.fire(SelectionEventManager.java:57)
	at org.openstreetmap.josm.data.osm.event.SelectionEventManager.fireEvent(SelectionEventManager.java:203)
	at org.openstreetmap.josm.data.osm.event.SelectionEventManager.lambda$selectionChanged$0(SelectionEventManager.java:198)
	at java.awt.event.InvocationEvent.dispatch(Unknown Source)
	at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.awt.EventQueue.access$500(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.run(Unknown Source)

Attachments (0)

Change History (18)

comment:1 Changed 7 months ago by Don-vip

Summary: when deleting last point of a waterwayDataIntegrityProblemException: Primitive must be part of the dataset (create multipolygon)

comment:2 Changed 7 months ago by Don-vip

Ticket #14857 has been marked as a duplicate of this ticket.

comment:3 Changed 7 months ago by Don-vip

Keywords: selection multipolygon added
Milestone: 17.06

comment:4 Changed 7 months ago by Don-vip

Keywords: backspace added

ok reproduced as follows:

  1. create a new closed way of three nodes
  2. Hit backspace three times: crash occurs on the third time

bug does not occur if we use Ctr-Z rather than backspace key.

comment:5 Changed 7 months ago by Don-vip

r12040 works, r12057 fails

comment:6 Changed 7 months ago by Don-vip

Cc: michael2402 added

Regression of r12043:12057

comment:7 Changed 7 months ago by Don-vip

Summary: DataIntegrityProblemException: Primitive must be part of the dataset (create multipolygon)DataIntegrityProblemException when backspace is used several times to revert the creation of a closed way

comment:8 Changed 6 months ago by Don-vip

Cc: michael2402 removed
Owner: changed from team to michael2402

comment:9 Changed 6 months ago by michael2402

In 12329/josm:

See #14854: Selection change listeners should not re-add the primitives that are removed to the selection.

comment:10 Changed 6 months ago by michael2402

Resolution: fixed
Status: newclosed

In 12330/josm:

Fix #14854: Run DrawAction selection listener and related UI updates in EDT.

comment:11 Changed 6 months ago by Don-vip

Ticket #14912 has been marked as a duplicate of this ticket.

comment:12 Changed 6 months ago by Don-vip

Ticket #14919 has been marked as a duplicate of this ticket.

comment:13 Changed 6 months ago by Don-vip

Ticket #14925 has been marked as a duplicate of this ticket.

comment:14 Changed 6 months ago by Don-vip

Ticket #14928 has been marked as a duplicate of this ticket.

comment:15 Changed 6 months ago by Don-vip

Keywords: regression added
Priority: normalmajor

comment:16 Changed 6 months ago by Don-vip

Ticket #14940 has been marked as a duplicate of this ticket.

comment:17 Changed 6 months ago by Don-vip

Ticket #14941 has been marked as a duplicate of this ticket.

comment:18 Changed 6 months ago by Don-vip

Ticket #14943 has been marked as a duplicate of this ticket.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain michael2402.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.