Modify

Opened 5 months ago

Closed 5 months ago

Last modified 4 months ago

#14840 closed enhancement (fixed)

[patch] Add separation borders to search screen

Reported by: jidanni Owned by: bafonins
Priority: minor Milestone: 17.06
Component: Core Version:
Keywords: search Cc: bafonins

Description (last modified by Don-vip)

Please add some borders as show below:


Attachments (11)

josmSearch.jpg (29.0 KB) - added by jidanni 5 months ago.
search-old.jpg (110.2 KB) - added by bafonins 5 months ago.
search-expert-new.jpg (109.3 KB) - added by bafonins 5 months ago.
search-new.jpg (54.8 KB) - added by bafonins 5 months ago.
ticket14840.patch (15.0 KB) - added by bafonins 5 months ago.
Refactored Search Dialog
ticket14840_2.patch (12.2 KB) - added by bafonins 5 months ago.
Merged supplied patch with the latest release of JOSM.
ticket14840_3.patch (11.8 KB) - added by bafonins 5 months ago.
Resolved minor ant-checkstyle warnings
14840-v4.patch (11.8 KB) - added by bafonins 5 months ago.
Just for convenience, merged two previous patched into one
Suche.png (31.4 KB) - added by Klumbumbus 5 months ago.
s-dialog.jpg (131.7 KB) - added by bafonins 5 months ago.
Fixed alignment
14840-alignment-fix.patch (1.7 KB) - added by bafonins 5 months ago.
Sorry for that, this should fix the issue with the alignment

Download all attachments as: .zip

Change History (28)

Changed 5 months ago by jidanni

Attachment: josmSearch.jpg added

comment:1 Changed 5 months ago by Don-vip

Description: modified (diff)
Keywords: search added

Changed 5 months ago by bafonins

Attachment: search-old.jpg added

Changed 5 months ago by bafonins

Attachment: search-expert-new.jpg added

Changed 5 months ago by bafonins

Attachment: search-new.jpg added

comment:2 Changed 5 months ago by bafonins

Hi!

Spent some time on it, would like to show the results.
Here is the old version, view in the expert mode :

Here is the new version, again in the expert mode :

And finally, the regular mode :

In my opinion, looks more compact and structured. Any suggestions?

comment:3 Changed 5 months ago by stoecker

Missing the patch file.

"Search examples" is wrong, as only some are examples, most are ready to use clicks.

Changed 5 months ago by bafonins

Attachment: ticket14840.patch added

Refactored Search Dialog

comment:4 Changed 5 months ago by Klumbumbus

Summary: Add separation borders to search screen[patch] Add separation borders to search screen

comment:5 Changed 5 months ago by stoecker

Your patch contains lot of stuff which should not be there including reverts of changes done recently.

Changed 5 months ago by bafonins

Attachment: ticket14840_2.patch added

Merged supplied patch with the latest release of JOSM.

comment:6 in reply to:  3 Changed 5 months ago by michael2402

Cc: bafonins added

Replying to stoecker:

"Search examples" is wrong, as only some are examples, most are ready to use clicks.

Examples that are useful are the best ones ;-).

I think "hints" is a better word. Or "syntax" (but it is not a real syntax definition, so "hints on search syntax"?)

I can do the merging next week (after I figured out the backspace-bug)

Last edited 5 months ago by michael2402 (previous) (diff)

Changed 5 months ago by bafonins

Attachment: ticket14840_3.patch added

Resolved minor ant-checkstyle warnings

comment:7 Changed 5 months ago by jidanni

Nice design.

Changed 5 months ago by bafonins

Attachment: 14840-v4.patch added

Just for convenience, merged two previous patched into one

comment:8 Changed 5 months ago by michael2402

Resolution: fixed
Status: newclosed

In 12333/josm:

Fix #14840: Add separation borders to search dialog. Patch by bafonins

comment:9 Changed 5 months ago by Don-vip

Milestone: 17.06

comment:10 Changed 5 months ago by Don-vip

Priority: trivialminor

comment:11 Changed 5 months ago by Don-vip

Nice, thanks! :)

Changed 5 months ago by Klumbumbus

Attachment: Suche.png added

comment:12 Changed 5 months ago by Klumbumbus

In localized JOSM it looks a bit strange. Could the text of the three blocks on the left made left aligned?


comment:13 Changed 5 months ago by Klumbumbus

Wouldn't "Syntax" be a better name for the block "Search Options"?

comment:14 Changed 5 months ago by Klumbumbus

Resolution: fixed
Status: closedreopened

comment:15 Changed 5 months ago by michael2402

Owner: changed from team to bafonins
Status: reopenednew

Changed 5 months ago by bafonins

Attachment: s-dialog.jpg added

Fixed alignment

Changed 5 months ago by bafonins

Attachment: 14840-alignment-fix.patch added

Sorry for that, this should fix the issue with the alignment

comment:16 Changed 5 months ago by michael2402

Resolution: fixed
Status: newclosed

In 12345/josm:

Apply #14840: Fix alignment in search dialog. Patch by bafonins

comment:17 Changed 4 months ago by jidanni

Thanks.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain bafonins.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.