Opened 9 months ago

Closed 9 months ago

Last modified 9 months ago

#14789 closed enhancement (fixed)

Toolbar presets text should contain group name as an option. Now is always displayed and clutters toolbar.

Reported by: dido Owned by: team
Priority: normal Milestone: 17.05
Component: Core Version:
Keywords: Cc:


When adding a preset item to the toolbar, button inherits preset group and name in the form of 'grop/item', e.g. 'highways/secondary', 'highways/primary', etc.

Typically one holds several preset items on the toolbar so showing only name, only icon or both is quite enough. Adding the group name (group names can be long) clutters the toolbar unnecessarily so it is a good idea to show it only as an option.

Attachments (0)

Change History (13)

comment:1 Changed 9 months ago by Don-vip

Priority: majornormal

comment:2 Changed 9 months ago by stoecker

Owner: changed from team to dido
Status: newneedinfo

The toolbar only contains icons. Names are only shown as mouseover. What are you talking about?

comment:3 Changed 9 months ago by Klumbumbus

Text is shown, when there is no icon set in the preset file (or the icon path not available).
(Regarding the default internal preset this is a rare case. Some in craft group and a hand full of others.)

comment:4 Changed 9 months ago by dido

Here how it looks like:

Group description 'Път/' is useless here. Text that is semantically important is the preset name only.

comment:5 Changed 9 months ago by Klumbumbus

Owner: changed from dido to team
Status: needinfonew

comment:6 Changed 9 months ago by stoecker

Proper solution is to provide images for the missing entries. A special workaround is nothing JOSM should support. Only other possibility I see is to allow manual override of name and image.

comment:7 Changed 9 months ago by stoecker

Resolution: fixed
Status: newclosed

In 12142/josm:

fix #14789 - allow to override toolbar image and toolbar name for presets

comment:8 Changed 9 months ago by stoecker

Milestone: 17.05

comment:9 Changed 9 months ago by dido

No special workaround needed, just remove the group name from the button's caption as it gives no useful information anyway.

comment:10 in reply to:  9 Changed 9 months ago by stoecker

Replying to dido:

No special workaround needed, just remove the group name from the button's caption as it gives no useful information anyway.

The group name is important, as there are presets with identical name, but totally different groups. E.g. like residential, which can be a street or an area or and building. Together with external presets there are a lot of duplications.

comment:11 Changed 9 months ago by dido

For sure you are right for those that want to get lost into hundreds of buttons with text presets into the ribbon. The other half just do not need the group name around. That's why I propose an option switch to control this, either in advanced options or anywhere else.

comment:12 Changed 9 months ago by stoecker

Hell, what do you want?

You're the first complaining about this in years which clearly indicates this is a minor issue. I added the option, so that you can individually set icon and displayname. What else do you want? As said, there wont be a workaround for such a special case! Stop bickering!

If you want to help simply provide proper icons for the few entries missing an icon!

comment:13 Changed 9 months ago by dido

Actually I do not want something more but something less :-)

As you clearly stated you've added display name and display icon. That makes sense because there are people that prefer to get pictorial description of what they use (icon, egyptians?) and others that are used to textual description (me personally, phoenicians?).

Maybe you've noticed that the preset ribbon does not overflow but all further added items just disappear to the right. Then it is obvious that if I get a group name along the actual preset name in interest, I can only fit e.g. 5 buttons on the ribbon. Otherwise I would fit 10 buttons which makes a pretty good sense to want this reduction feature.

Here I do not bicker but object the common sense behind my request as it is quite obvious that will introduce an improvement in JOSM's UI. If you generally reject doing either minor or major enhancements in JOSM, I would then have to agree with that fact and apologize for the time taken :-)


Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.