[PATCH] Add method to apply virtual node to multiple ways

[dieterdreist@…]

the refine nodes in selection mode (plus) is not working for overlapping ways. It should add nodes in all parts of the overlapping way, not just in the upper one.

[anonymous]

This is not intended. It will not connect ways. The new node is added in the selected way (previous selection use middle mouse or other methods works here too).

To add nodes to all ways use draw tool.

[dieterdreist]

sorry for the new attempt, but I dare to try again: I agree that it is not the desired functionality for ways which conincidentally overlap (without sharing adjacent nodes), but if two ways are overlapping at a given point and share the next node in both directions, this is in 98% of the cases the desired behaviour (often we are refining "rough" ways to put more precise information). This would be the case for all adjacent landuses, for buildings on the corner of squares, etc.

Otherwise the "red-plus"-function is not useful for refining overlapping ways as too complicated: for each single node to insert you would have to

1. drag first plus
2. drag the second plus below near the new node from 1.
3. merge the nodes from 1 and 2
4. move the merged node from 3 to the right position

but also a standard adding is mode-change-intensive:

1. add a new node
2. change to select-mode
3. move the new node
4. go back to 1 for the next mode.

[stoecker]

Possible we can add a modifier like "Ctrl" to reach the requested behaviour.

[xeen]

Patch adds ALT as modifier to insert the virtual node into all ways that share this segment. This means it doesn't work for ways that only coincidentally have their virtual nodes on top of each other. E.g. the following example will only have the virtual node added to one of the ways:

   |
 --+--
   |

This feature is not exposed anywhere, status bar is already full anyway. Might want add this to the Advanced Features page in the OSM wiki though.

I found a call to updateStatusLine that I deem superfluous and also one to repaint(). For every move and select action this saves one redraw which should be a nice speed improvement if it works out as planned.

[stoecker]

Applied in r1441.

P.S. trn() is used to separate between 1/many. This also works for foreign languages :-)

[stoecker]

Ticket #2734 has been marked as a duplicate of this ticket.