Modify

Opened 7 years ago

Closed 7 years ago

#14632 closed defect (fixed)

[PATCH] "Mark selected" not displayed (broken)

Reported by: bagage Owned by: Gnonthgol
Priority: normal Milestone:
Component: Plugin todo Version: latest
Keywords: template_report github Cc:

Description

What steps will reproduce the problem?

  1. Add items to todo list
  2. Select them on the map
  3. Right click on the todo list

What is the expected result?

A contextual menu "mark selected" should appear, and on click this will mark selected items "done".

What happens instead?

The entry is not displayed and instead a 1px line is shown.

Please provide any additional information below. Attach a screenshot if possible.

The right-click popup menu is created BEFORE the "Mark selected" action is actually constructed, so an empty entry is shown in the menu instead.
Reordering fix the problem. See also the PR on github (https://github.com/JOSM/todo/pull/2).

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2017-04-02 01:45:00 +0200 (Sun, 02 Apr 2017)
Build-Date:2017-04-02 01:34:50
Revision:11826
Relative:URL: ^/trunk

Identification: JOSM/1.5 (11826 en) Linux Debian GNU/Linux 9.0 (stretch)
Memory Usage: 818 MB / 1760 MB (419 MB allocated, but free)
Java version: 1.8.0_121-8u121-b13-4-b13, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java package: openjdk-8-jre:amd64-8u121-b13-4
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-13
Program arguments: [--language=en, ${HOME}/majcadastre/CL301-SAINT-DONAT-SUR-L HERBASSE/CL301-SAINT-DONAT-SUR-L HERBASSE-houses-prediction_segmente.osm]
Dataset consistency test: No problems found

Plugins:
+ buildings_tools (33004)
+ conflation (0.5.4)
+ jts (32699)
+ todo (30000)
+ utilsplugin2 (33212)

Last errors/warnings:
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$SelectAction@450e4d21
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$AddAction@60106b50
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$PassAction@31734286
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$MarkAction@4d5695f7

Attachments (1)

0001-Fix-contextual-menu-entry-Mark-selected-that-was-not.patch (1.7 KB ) - added by bagage 7 years ago.
patch proposal

Download all attachments as: .zip

Change History (2)

comment:1 by Don-vip, 7 years ago

Keywords: github added
Resolution: fixed
Status: newclosed

Thanks! Side note: no need to create a ticket here for Github-hosted projects :)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Gnonthgol.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.