Modify

Opened 9 days ago

Closed 9 days ago

Last modified 9 days ago

#14536 closed enhancement (fixed)

[PATCH] Improved ExifReader.readTime(), Refactored ImageEntry.extractExif()

Reported by: holgermappt Owned by: team
Priority: minor Milestone: 17.03
Component: Core image mapping Version: latest
Keywords: exif Cc:

Description

The patch improves ExifReader.readTime() and moves code from ImageEntry.extractExif() to ExifReader.

ExifReader.readTime():

  • Use the right SUBSECOND depending on the EXIF tag that was used for the date.

Code refactoring:

  • Use the metadata structure to extract EXIF data instead of parsing the image file multiple times.
  • Speed and elevation extraction moved to ExifReader.
  • Added unit tests for speed and elevation extraction.

Smaller image file for ticket 14209.

Attachments (3)

GeoImageLayer_ExifReader_refactoring.patch (14.6 KB) - added by holgermappt 9 days ago.
Patch file.
exif-example_speed_ele.jpg (515 bytes) - added by holgermappt 9 days ago.
Image file with speed and elevation data.
7VWFOryj--.1.jpg (670 bytes) - added by holgermappt 9 days ago.
Smaller image file with same issue for ticket #14209.

Download all attachments as: .zip

Change History (6)

Changed 9 days ago by holgermappt

Patch file.

Changed 9 days ago by holgermappt

Attachment: exif-example_speed_ele.jpg added

Image file with speed and elevation data.

Changed 9 days ago by holgermappt

Attachment: 7VWFOryj--.1.jpg added

Smaller image file with same issue for ticket #14209.

comment:1 Changed 9 days ago by Don-vip

Keywords: exif added
Milestone: 17.03

comment:2 Changed 9 days ago by Don-vip

Resolution: fixed
Status: newclosed

In 11745/josm:

fix #14536 - Improved ExifReader.readTime(), Refactored ImageEntry.extractExif() (patch by holgermappt)

comment:3 Changed 9 days ago by Don-vip

thanks! :)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.