Modify

Opened 4 months ago

Last modified 4 weeks ago

#14532 new enhancement

check for invalid "layer" tagging on tunnel=* and bridge=*

Reported by: mdk Owned by: team
Priority: normal Milestone:
Component: Core validator Version: latest
Keywords: Cc: naoliv

Description

I found several wrong taggings for tunnel=* and bridge=*. For example I found lots of tunnel=* without layer=-1, but instead with ele=-1, level=-1 or width=-1. Theoretically also -2, -3 and so on, but I only saw -1. The same with bridge=*, but positive numbers. Sometimes the are also fixes by adding the missing layer=* tag, but leaving the other ones. In my opinion negative width values are always a failure. Only positive width values on highway=* and waterway=* could be valid.

It would be nice, if the validator would warn about ways with

  • waterway=*, tunnel=* level=-1
  • waterway=*, tunnel=* ele=-1
  • waterway=*, tunnel=* width=-1
  • highway=*, bridge=* level=1
  • highway=*, bridge=* ele=1

and offer correction to layer=*

Attachments (0)

Change History (3)

comment:1 Changed 4 months ago by naoliv

Cc: naoliv added

comment:2 Changed 4 weeks ago by Klumbumbus

Could you give numbers how often these cases appear in the database?

comment:3 Changed 4 weeks ago by naoliv

[waterway][tunnel][level] = 3095 ways (2992 without layer)
It seems that level is always wrong here (having layer or not)

[waterway][tunnel][ele] = 187 ways (91 with ele = -1)
I think that it also doesn't make sense to have ele in waterways

For width = -1 JOSM already detects and warns about the invalid negative value.

[highway][bridge][level] = 6956 ways
Randomly picked some and they all should be layer instead.

[highway][bridge][ele] = 1014 ways
Random picks also seemed wrong usage of ele

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user. Next status will be 'new'.
Next status will be 'needinfo'.The owner will change to mdk
as duplicate The resolution will be set to duplicate. Next status will be 'closed'.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.