Modify

Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#14444 closed enhancement (fixed)

[PATCH] New icon for shop=lottery 👾

Reported by: naoliv Owned by: naoliv
Priority: normal Milestone: 17.03
Component: Internal mappaint style Version:
Keywords: Cc:

Description

I was fixing something when I saw this in JOSM:
https://i.imgur.com/rwrz0Tq.png

And I thought "What is this alien in the map?"
https://i.imgur.com/FW9unWT.png

Maybe it could be possible to use something else for shop=lottery that doesn't resemble a brain with two eyes? :-)

JOSM:

Build-Date:2017-03-01 23:16:26
Revision:11644
Is-Local-Build:true

Identification: JOSM/1.5 (11644 SVN pt_BR) Linux Debian GNU/Linux 9.0 (stretch)
Memory Usage: 599 MB / 3005 MB (162 MB allocated, but free)
Java version: 1.8.0_121-8u121-b13-3-b13, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java package: openjdk-8-jre:amd64-8u121-b13-3
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-13
VM arguments: [-Dawt.useSystemAAFontSettings=on]
Dataset consistency test: No problems found

Attachments (1)

lottery.svg (11.7 KB) - added by naoliv 3 months ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 3 months ago by Klumbumbus

Owner: changed from team to naoliv
Status: newneedinfo

It is this in big:

source:trunk/images/presets/shop/lottery.svg

Can you provide a better icon?

comment:2 Changed 3 months ago by Don-vip

I discover the alien monster unicode character thanks to this ticket, nice :) I wonder if some day we will be able to provide a "text-only" mappaint style :)

comment:3 Changed 3 months ago by naoliv

@Klumbumbus
Is the icon maximum size 16x16?
Something like this maybe?
https://i.imgur.com/TQ1pOWU.png
or
https://i.imgur.com/OjXV4eg.png

Attached is the second version.

@Don-vip, see http://apps.timwhitlock.info/emoji/tables/unicode

Changed 3 months ago by naoliv

Attachment: lottery.svg added

comment:4 in reply to:  3 ; Changed 3 months ago by Klumbumbus

Replying to naoliv:

Is the icon maximum size 16x16?

It is the default size in the mapview. With future hidpi support (#9995) and a hidpi screen we will see more pixels sometime.

Attached is the second version.

Whats the source and license?

(see also DevelopersGuide/DefaultPresets#NewIcons)

comment:5 in reply to:  4 ; Changed 3 months ago by naoliv

Replying to Klumbumbus:

Whats the source and license?

It was a modification from source:trunk/images/presets/shop/lottery.svg
If it allows to modify and reuse it, you can consider what I did as public domain and/or CC0.

comment:6 Changed 3 months ago by Don-vip

Milestone: 17.03
Summary: New icon for shop=lottery 👾[PATCH] New icon for shop=lottery 👾

I like it :)

comment:7 in reply to:  5 Changed 3 months ago by Klumbumbus

Replying to naoliv:

It was a modification from source:trunk/images/presets/shop/lottery.svg
If it allows to modify and reuse it, you can consider what I did as public domain and/or CC0.

Thanks. The old one is CC0 licensed (see https://josm.openstreetmap.de/browser/josm/trunk/images/presets/lottery.svg?rev=6855)

comment:8 Changed 3 months ago by Klumbumbus

Resolution: fixed
Status: needinfoclosed

In 11663/josm:

  • fix #14444 - new lottery icon by naoliv, CC0 and PD licensed
  • fix #14454 - fix Narrow Gauge Rail preset link

comment:9 Changed 3 months ago by Klumbumbus

I resized your icon to 16 px. Icons, which can't be resized exactly to 16 px are rounded down to 15px in JOSM or JAVA (?) or something like this and therefore look bad within JOSM.

comment:10 in reply to:  9 Changed 3 months ago by naoliv

Replying to Klumbumbus:

I resized your icon to 16 px. Icons, which can't be resized exactly to 16 px are rounded down to 15px in JOSM or JAVA (?) or something like this and therefore look bad within JOSM.

Sure. Thank you!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain naoliv.
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.