Modify

Opened 8 months ago

Closed 8 months ago

Last modified 8 months ago

#14410 closed defect (fixed)

[PATCH] AddPrimitivesCommand undo remove existing data

Reported by: Tyndare Owned by: team
Priority: major Milestone: 17.02
Component: Core Version:
Keywords: AddPrimitivesCommand undo existing conflation Cc:

Description

The AddPrimitivesCommand is supposed to ignore existing data (there is a test for that: testAddIgnoresExisting())
But if we undo the command, the data that was already existing will be removed and not ignored, leaving an incoherent state.

This is causing major exception when we use "undo" with the Conflation plugin which rely on this command.

The attached patch save the state of pre existing data, and in case of undo restore their state instead of removing them from the DataSet.

I also took the liberty to try to simplify the code that handle selection (toSelect), feel free to ignore this part.

Attachments (1)

AddPrimitivesCommand-undo-existing.patch (7.8 KB) - added by Tyndare 8 months ago.
PATCH

Download all attachments as: .zip

Change History (4)

Changed 8 months ago by Tyndare

PATCH

comment:1 Changed 8 months ago by Don-vip

Milestone: 17.02

comment:2 Changed 8 months ago by Don-vip

Resolution: fixed
Status: newclosed

In 11609/josm:

fix #14410 - AddPrimitivesCommand undo remove existing data (patch by Tyndare)

comment:3 Changed 8 months ago by Don-vip

thanks! :)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.