Modify

#14402 closed defect (fixed)

hasAreaTags returns true for natural=cliff, natural=tree_row or natural=coastline

Reported by: Stereo Owned by: team
Priority: normal Milestone: 17.02
Component: Core Version:
Keywords: natural Cc:

Description

hasAreaTags() is quite basic - it only checks for natural=* to decide that an object has area tags. This is causing issues with, for example, the reltoolbox plugin's rebuild polygon function.

https://taginfo.openstreetmap.org/keys/natural#values finds a few counterexamples where a way with natural=* isn't an area: at least cliff, tree_row, coastline. For leisure=*, I can think of leisure=track and leisure=slipway.

Attachments (0)

Change History (7)

comment:1 Changed 10 months ago by Don-vip

Keywords: natural added; OsmPrimitive removed
Milestone: 17.02

comment:2 Changed 10 months ago by Don-vip

Resolution: fixed
Status: newclosed

In 11600/josm:

fix #14402 - add whitelist for natural area values to avoid false positives

comment:3 Changed 10 months ago by Stereo

Resolution: fixed
Status: closedreopened

Can you please also whitelist leisure=track and leisure=slipway?

comment:4 Changed 10 months ago by Don-vip

You mean blacklist right?

comment:5 Changed 10 months ago by Stereo

Ah, I mean they're not an area.

comment:6 Changed 10 months ago by Don-vip

This is not clear for leisure=track, see osmwiki:Tag:leisure=track, I prefer not to change the current behaviour.

but leisure=picnic_table/slipway/firepit are not areas.

Last edited 10 months ago by Don-vip (previous) (diff)

comment:7 Changed 10 months ago by Don-vip

Resolution: fixed
Status: reopenedclosed

In 11608/josm:

fix #14402 - add blacklist for leisure area values to avoid false positives - improve globally the detection of keys/tags

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.