Modify

Opened 8 months ago

Closed 8 months ago

Last modified 8 months ago

#14370 closed defect (fixed)

the plugin list import function has trouble with more advanced plugin version numbers

Reported by: Klumbumbus Owned by: team
Priority: normal Milestone: 17.02
Component: Core Version:
Keywords: template_report Cc: michael2402, stoecker

Description

What steps will reproduce the problem?

  1. import e.g. the plugin list from this status report via preferences -> plugins -> load from list
  2. error message Mapillaryv1.3.2)

caused by either the dots or the v (or both).

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2017-02-14 00:32:15 +0100 (Tue, 14 Feb 2017)
Build-Date:2017-02-13 23:35:58
Revision:11560
Relative:URL: ^/trunk

Identification: JOSM/1.5 (11560 de) Windows 10 64-Bit
Memory Usage: 560 MB / 1063 MB (232 MB allocated, but free)
Java version: 1.8.0_121-b13, Oracle Corporation, Java HotSpot(TM) Client VM
Screen: \Display0 1680x1050
Maximum Screen Size: 1680x1050
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Program Files (x86)\josm-latest-mehr-RAM.jnlp, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=256m,1100m, -Djnlpx.splashport=52950, -Djnlpx.jvm=<java.home>\bin\javaw.exe]

Plugins:
+ AddrInterpolation (33005)
+ DirectDownload (33004)
+ DirectUpload (32885)
+ FastDraw (33004)
+ HouseNumberTaggingTool (32699)
+ Mapillary (v1.3.2)
+ OpeningHoursEditor (33004)
+ Tracer2 (33004)
+ alignways (33136)
+ apache-commons (32994)
+ apache-http (32699)
+ buildings_tools (33004)
+ contourmerge (1030)
+ editgpx (33004)
+ imagery-xml-bounds (33004)
+ imagery_offset_db (33004)
+ log4j (32699)
+ measurement (33088)
+ osm-obj-info (1484152384)
+ photo_geotagging (33088)
+ photoadjust (33088)
+ reltoolbox (33088)
+ reverter (33088)
+ tag2link (33035)
+ tageditor (33021)
+ tagging-preset-tester (33004)
+ terracer (33088)
+ turnlanes-tagging (254)
+ turnrestrictions (33088)
+ undelete (32699)
+ utilsplugin2 (33124)
+ wikipedia (33098)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/OneClick&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/StolpersteineLight&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1
+ %UserProfile%\Documents\OSM\JOSMSVN\data\defaultpresets.xml
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/DE.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/Industrial&zip=1

Map paint styles:
+ %UserProfile%\Documents\OSM\JOSMSVN\styles\standard\elemstyles.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/HiDPISupport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
- %UserProfile%\Documents\OSM\eigene styles\maxspeed\maxspeed_2.8_01 zeige richtungspfeile.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/sac_scale&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ShowID&zip=1
- %UserProfile%\Documents\OSM\eigene styles\PriorityRoad\PriorityRoad_1.0.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/LayerChecker&zip=1
- %UserProfile%\Documents\OSM\TestNew\newicons.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&style&zip=1
- %UserProfile%\Documents\OSM\patches\old MPs\dataquality.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Sidewalks&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Cycleways&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Osmc&style&zip=1
- https://raw.githubusercontent.com/species/josm-preset-wheelchair/master/sidewalks_kerbs.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/LitObjects&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lit&style&zip=1
- %UserProfile%\Documents\OSM\eigene styles\Tourenplanung.mapcss
- %UserProfile%\Documents\OSM\eigene styles\SpecificBuildingValues\SpecificBuildingValues.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
- https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip
- http://www.openrailwaymap.org/styles/standard.mapcss
- %UserProfile%\Documents\OSM\eigene styles\area-symbol.zip
- http://www.freietonne.de/ft_icons/josm/FreieTonne_rules_presets_zip.php
- https://josm.openstreetmap.de/josmfile?page=Styles/NewHighwayColors&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/MaxspeedIcons&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/DestinationSignRelation&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Incline&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PTStops&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/AdvertisingStyle&zip=1
- https://www.dropbox.com/s/qo3ai47fpv241jf/Styles_Fixme_and_Notes.zip?raw=1
- https://github.com/gmgeo/osmic-josm-style/archive/master.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/hazmat&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Suburb&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Postcode&zip=1

Validator rules:
+ https://raw.githubusercontent.com/<user.name>n-a-bauer/josm-validators/master/mtb.validator.mapcss
+ %UserProfile%\Documents\OSM\TestNew\new.validator.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/GermanySpecific&zip=1
- %UserProfile%\Documents\OSM\TestNew\germ.validator.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/CzechRepublicAddressSystem&zip=1

Last errors/warnings:
- E: java.io.IOException: Die angeforderte URL http://osmlab.github.io/editor-layer-index/imagery.xmlx wurde nicht gefunden
- W: No url returned for: {0}, skipping
- W: java.lang.IllegalArgumentException: No url returned
- W: No url returned for: {0}, skipping
- W: java.lang.IllegalArgumentException: No url returned
- W: java.net.MalformedURLException: unknown protocol: c
- E: java.io.IOException: Die angeforderte URL http://osmlab.github.io/editor-layer-index/imagery.xmlx wurde nicht gefunden
- E: java.io.IOException: Die angeforderte URL http://osmlab.github.io/editor-layer-index/imagery.xmlx wurde nicht gefunden

Attachments (0)

Change History (14)

comment:1 Changed 8 months ago by Klumbumbus

Cc: michael2402 added

comment:2 Changed 8 months ago by Don-vip

Milestone: 17.02

comment:3 Changed 8 months ago by Don-vip

Resolution: fixed
Status: newclosed

In 11563/josm:

fix #14370 - plugin list import function has trouble with more advanced plugin version numbers

comment:4 Changed 8 months ago by michael2402

In 11564/josm:

See #14370: Allow a(lpha), b(eta) in plugin version names as well. Force them to not match the plugin names.

comment:5 Changed 8 months ago by michael2402

I just noticed that we have few plugin names ending in 'v' ;-)

comment:6 Changed 8 months ago by michael2402

In 11565/josm:

See #14370: Explain that pattern

comment:7 Changed 8 months ago by Klumbumbus

Resolution: fixed
Status: closedreopened

There is still a problem with + mbtiles (v2.0-4-g1006305)

Also the plugin ​kendzi3d_Improved_by_Andrei has a strange version (1.0.179-SNAPSHOT ), however in the statusreport its version is completely missing:

...
+ kendzi3d-resources (0.0.1)
+ kendzi3d_Improved_by_Andrei
+ log4j (32699)
...

Can we "simply" allow everything between the two curved brackets, so the import function is more future proof?

comment:8 Changed 8 months ago by Don-vip

I plan to release new tested tomorrow. Michael, will you have time to fix the regex?

comment:9 in reply to:  8 Changed 8 months ago by Klumbumbus

Replying to Don-vip:

I plan to release new tested tomorrow.

Please make an i18n update today, so we can check the translation within JOSM before the release. (In current tested there are the translated strings of the gps heat map mode missing).

comment:10 Changed 8 months ago by Don-vip

Cc: stoecker added

Not possible today, there are errors in French translation. But Dirk has fixed them, I suppose he's planning to do it tomorrow o:)

comment:11 in reply to:  10 Changed 8 months ago by stoecker

Replying to Don-vip:

Not possible today, there are errors in French translation. But Dirk has fixed them, I suppose he's planning to do it tomorrow o:)

Already downloaded recent launchpad data. Doing the update soon.

comment:12 Changed 8 months ago by michael2402

I'll fix it tomorrow morning.

comment:13 Changed 8 months ago by michael2402

Resolution: fixed
Status: reopenedclosed

In 11636/josm:

Fix #14370: Allow all characters in plugin versions, except for ( and ).

comment:14 Changed 8 months ago by michael2402

Sorry, took a bit longer to get it committed.

My default update work flow involves github, which is down since Jan 27: https://github.com/openstreetmap/josm

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.