Modify

Opened 10 months ago

Closed 10 months ago

Last modified 10 months ago

#14247 closed enhancement (fixed)

Change names in heat map combobox

Reported by: anonymous Owned by: team
Priority: normal Milestone: 17.01
Component: Core Version: latest
Keywords: template_report gpx heatmap Cc: kidelo

Description

What steps will reproduce the problem?

  1. Open preferences
  2. Open combobox for change color schema for heat map.
  3. The names in combobox is not color names I think.


What is the expected result?

Names that is color names.

Maybe something like what I can see in the code.
Wood -> brown2green
Heat -> red2blue

What happens instead?

Names that is not color names.
Wood is already translated, but in the meaning for material.

Please provide any additional information below. Attach a screenshot if possible.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2017-01-14 21:10:48 +0100 (Sat, 14 Jan 2017)
Build-Date:2017-01-15 02:35:18
Revision:11463
Relative:URL: ^/trunk

Identification: JOSM/1.5 (11463 en) Windows XP 32-Bit
Memory Usage: 231 MB / 247 MB (106 MB allocated, but free)
Java version: 1.8.0_111-b14, Oracle Corporation, Java HotSpot(TM) Client VM
Screen: \Display0 1152x864
Maximum Screen Size: 1152x864
VM arguments: [-Duser.home=%UserProfile%]

Plugins:
+ BuildingGeneralization (1010)
+ DxfImport (1008)
+ Mapillary (v1.3.2)
+ PicLayer (33088)
+ ShapeTools (1220)
+ apache-commons (32994)
+ apache-http (32699)
+ areaselector (1478814827)
+ continuosDownload (53)
+ junctionchecking (33088)
+ log4j (32699)
+ pdfimport (33004)
+ pt_assistant (33108)
+ reverter (33088)
+ tageditor (33021)
+ todo (30000)
+ turnlanes-tagging (254)
+ turnrestrictions (33088)
+ utilsplugin2 (33088)
+ wikipedia (33098)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1

Last errors/warnings:
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$SelectAction@138c01a
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$AddAction@1a69953
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$PassAction@4eaab4
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$MarkAction@e06e61
- W: Unable to get color from '' for color preference 'extrude.main.line'
- W: Unable to get color from '' for color preference 'improve.way.accuracy.helper.line'
- W: Unable to get color from '' for color preference 'make.parallel.helper.line'
- W: Unable to get color from '' for color preference 'extrude.main.line'
- W: Unable to get color from '' for color preference 'improve.way.accuracy.helper.line'
- W: Unable to get color from '' for color preference 'make.parallel.helper.line'

Attachments (8)

Color schema.PNG (11.2 KB) - added by anonymous 10 months ago.
josm_ticket_14247_gpx_heat_map_config_by_kidelo_v1.patch (10.7 KB) - added by kidelo 10 months ago.
Visualize GPX Heat Map Colors by kidelo, version 1
heatmap_cfg_inferno.png (7.2 KB) - added by kidelo 10 months ago.
heatmap_cfg_user_red.png (6.7 KB) - added by kidelo 10 months ago.
heatmap_cfg_virdis.png (6.8 KB) - added by kidelo 10 months ago.
heatmap_cfg_user_cyan.png (6.6 KB) - added by kidelo 10 months ago.
josm_ticket_14247_gpx_heat_map_config_by_kidelo_v2.patch (10.7 KB) - added by kidelo 10 months ago.
Visualize GPX Heat Map Colors by kidelo, version 2 - fix
heatmap_cfg_global.png (23.7 KB) - added by kidelo 10 months ago.

Download all attachments as: .zip

Change History (19)

Changed 10 months ago by anonymous

Attachment: Color schema.PNG added

comment:1 Changed 10 months ago by bastiK

I think the names are fine, but it would be nice to have icons that illustrate the corresponding gradient next to the text.

comment:2 Changed 10 months ago by Don-vip

Cc: kidelo added
Keywords: gpx heatmap added
Milestone: 17.01

comment:3 Changed 10 months ago by Don-vip

Where do the names come from exactly?

comment:4 in reply to:  3 Changed 10 months ago by kidelo

Replying to Don-vip:

Where do the names come from exactly?

Inferno + Viridis :
Names of well known common color maps

see:
https://cran.r-project.org/web/packages/viridis/vignettes/intro-to-viridis.html
http://bids.github.io/colormap/

Wood + Heat
Name choosen by myself. First impression where I have seen the result.

Last edited 10 months ago by kidelo (previous) (diff)

comment:6 Changed 10 months ago by Don-vip

OK. Agreed with bastiK, adding a visual indication with an icon should be enough.

Changed 10 months ago by kidelo

Visualize GPX Heat Map Colors by kidelo, version 1

Changed 10 months ago by kidelo

Attachment: heatmap_cfg_inferno.png added

Changed 10 months ago by kidelo

Attachment: heatmap_cfg_user_red.png added

Changed 10 months ago by kidelo

Attachment: heatmap_cfg_virdis.png added

Changed 10 months ago by kidelo

Attachment: heatmap_cfg_user_cyan.png added

comment:7 Changed 10 months ago by kidelo

Here comes the solution for that enhancement request, please check if it will work.

  • Preview Image (Icon) is generated based on selected heat map
  • works for static predefined color maps and for color map based on user defined reference color
  • no future effort needed when colors maps are changed, added or removed

See examples:



Changed 10 months ago by kidelo

Visualize GPX Heat Map Colors by kidelo, version 2 - fix

Changed 10 months ago by kidelo

Attachment: heatmap_cfg_global.png added

comment:8 Changed 10 months ago by kidelo

I have uploaded a fix for new introduced bug by first patch which prevents the usage of global configuration dialog without association to any layer. Now it works again.

comment:9 Changed 10 months ago by bastiK

Great! Did you consider moving the icon(s) into the combobox? Then you could see all of them at once.

comment:10 Changed 10 months ago by Don-vip

Resolution: fixed
Status: newclosed

In 11483/josm:

fix #14247 - add icon as a visual indication of chosen gpx heatmap (patch by kidelo)

comment:11 Changed 10 months ago by Don-vip

Great, thank you! :)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.