Modify

Opened 4 months ago

Closed 7 weeks ago

#14193 closed defect (fixed)

Relation Editor: On save conflicts with map view not properly detected

Reported by: darya Owned by: team
Priority: major Milestone: 17.03
Component: Core Version:
Keywords: template_report relation editor Cc:

Description

This is from darya:

I think I'm having a similar problem (similar/same stack trace). To reproduce:

  1. Open relation editor
  2. Create a new node (e.g. by copy+paste)
  3. Add that node to the relation. Don't close the relation editor
  4. While relation editor still open, remove the node in the map frame. (The deleted node will still be referenced by the relation)
  5. Press OK in the relation editor -> JOSM crash

If an existing node is used with an id>0, the problem does not occur. Instead, a dialog asks: "Deleting object. Please confirm to remove 1 object. 17 relation are affected".

Attachments (0)

Change History (4)

comment:1 Changed 4 months ago by skyper

I can reproduce and playing around with undo and redo I did end up with complete inconsistency where the object was still member in relation editor but it was not shown in the tag/membership toggle dialog and no exception was thrown:

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2017-01-02 22:50:04 +0100 (Mon, 02 Jan 2017)
Build-Date:2017-01-03 02:35:14
Revision:11428
Relative:URL: ^/trunk

Identification: JOSM/1.5 (11428 en) Linux Debian GNU/Linux 8.6 (jessie)
Memory Usage: 398 MB / 882 MB (288 MB allocated, but free)
Java version: 1.8.0_111-8u111-b14-2~bpo8+1-b14, Oracle Corporation, OpenJDK 64-Bit Server VM
Java package: openjdk-8-jre:amd64-8u111-b14-2~bpo8+1
Java ATK Wrapper package: libatk-wrapper-java:all-0.30.4-3
Program arguments: [--language=en]

Dataset consistency test:
[DELETED REFERENCED] {Relation id=2106112 version=128 VT [way 331034994, way 48815631, way 176021661, way 52580121, way 48866562, way 30441688, way 30880333, way 52580122, way 411103221, way 52580115, way 206389387, way 30705743, way 58463384, way 58516733, way 52580040, way 69284977, way 31901060, way 362341136, way 31901059, way 72241609, way 31542010, way 31461710, way 72241552, way 30409992, way 257326752, way 30443786, way 29734155, way 29411837, way 30334572, way 30334570, way 30334569, way 30334568, way 30334567, way 83198158, way 31477358, way 30275093, way 31480092, way 30275348, way 30275041, way 30449068, way 30790201, way 30790196, way 59858866, way 30334067, way 30334065, way 30334066, way 30334064, way 29413448, way 30334059, way 30334061, way 31528031, way 31528028, way 31513585, way 29546929, way 312443796, way 230804214, way 230806783, way 122975156, way 124761790, way 124761788, way 124761791, way 207355677, way 122974618, way 123770408, way 123770416, way 123770423, way 123271973, way 207354305, way 123271464, way 207352475, way 215405786, way 72864317, way 123271088, way 29413689, way 123270565, way 123270128, way 207348467, way 161401132, way 123269910, way 296096075, way 296096076, way 83198375, way 123269902, way 123269906, way 207244884, way 123269912, way 123269911, way 207243501, way 123269904, way 82456436, way 207238231, way 123246212, way 82456437, way 123246210, way 123246216, way 207243502, way 123246195, way 123246205, way 123246214, way 123246202, way 82456439, way 123246213, way 123246204, way 123246200, way 33904094, way 123626410, way 123626402, way 122946474, way 122946470, way 122946613, way 122946465, way 123626424, way 122946484, way 123626432, way 122944979, way 123626447, way 123626449, way 123623660, way 123623662, way 123623659, way 123623663, way 123623658, way 123623657, way 124997923, way 124997871, way 124997900, way 82455791, way 82455784, way 207233302, way 124997894, way 82455806, way 208758466, way 82455812, way 124997888, way 124997864, way 29411926, way 124997929, way 124997913, way 124997931, way 29412903, way 124997881, way 35829664, way 124997866, way 70138728, way 105901759, way 105901964, way 70039687, way 209044148, way 124997918, way 70032767, way 40469805, way 40471492, way 92514614, way 70032753, way 92514606, way 70039691, way 92514591, way 69568286, way 69568365, way 44815944, way 124315481, way 207174191, way 207174200, way 207168710, way 207168703, way 207168706, way 207162337, way 207159962, way 207162333, way 313419902, way 313419898, way 207159959, way 207162328, way 207159960, way 207162319, way 220528380, way 220528379, way 220528378, way 124053341, way 124053350, way 212102467, way 233681723, way 212102543, way 212102599, way 212102579, way 212102673, way 218264685, way 220963374, way 323979541, way 218323024, way 218303169, way 212102658, way 212102590, way 218303162, way 207159964, way 218294279, way 207159967, way 207159957, way 220140015, way 220140020, way 220140013, way 220140011, way 220140016, way 220140018, way 320172632, way 220140014, way 320168912, way 220076489, way 220073721, way 220073718, way 220073712, way 220150724, way 320069811, way 320069814, way 220150732, way 220150727, way 208663609, way 208663620, way 208663604, way 320077092, way 208663614, way 206772962, way 206772959, way 206772957, way 206772958, way 206772147, way 206772148, way 206772145, way 206907298, way 206908578, way 206908577, way 206907304, way 319869808, way 206907309, way 206907308, way 220776112, way 322433514, way 206907292, way 206907307, way 206907300, way 206773249, way 206773268, way 206773251, way 320614377, way 206773250, way 206773262, way 206759674, way 220179228, way 320958668, way 320962238, way 320632063, way 320962240, way 320630494, way 220288183, way 220288185, way 60667520, way 220771323, way 60107176, way 220771322, way 220771325, way 60107196, way 60667521, way 60667464, way 60667517, way 60667412, way 60107155, way 29413665, way 52580182, way 52580169, way 206883525, way 390111071, way 60107188, way 52580036, way 264219399, way 264219071, way 264219068, way 206895688, way 264217680, way 52580218, way 206895684, way 29412250, way 206895666, way 265698417, way 206895671, way 79093566, way 53255405, way 78756560, way 53255402, way 390211308, way 79096155, way 53255404, way 390598253, way 79096149, way 385907961, way 79096164, way 206914728, way 385903983, way 78756565, way 385903982, way 385854319, way 385893359, way 53255403, way 178127088, way 385854318, way 178127084, way 178127111, way 30340946, way 385866076, way 30340947, way 167104415, way 299003250, way 206914772, way 206914748, way 206914776, way 40471792, way 123620567, way 124062272, way 40471659, way 124997906, way 61049227, way 385893360, way 385893358, way 81763605, way 78756557, way 61191061, way 377854540, way 78756569, way 79096146, way 207162351, way 207159968, way 54436444, node 21973469, node -30883]} refers to deleted primitive {Node id=-30883 version=0 MVDT lat=48.002203038244915,lon=7.823909421016578}


Last errors/warnings:
- E: Handled by bug report queue: org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Deleted member referenced: {Relation id=2106112 version=128 VT [way 331034994, way 48815631, way 176021661, way 52580121, way 48866562, way 30441688, way 30880333, way 52580122, way 411103221, way 52580115, way 206389387, way 30705743, way 58463384, way 58516733, way 52580040, way 69284977, way 31901060, way 362341136, way 31901059, way 72241609, way 31542010, way 31461710, way 72241552, way 30409992, way 257326752, way 30443786, way 29734155, way 29411837, way 30334572, way 30334570, way 30334569, way 30334568, way 30334567, way 83198158, way 31477358, way 30275093, way 31480092, way 30275348, way 30275041, way 30449068, way 30790201, way 30790196, way 59858866, way 30334067, way 30334065, way 30334066, way 30334064, way 29413448, way 30334059, way 30334061, way 31528031, way 31528028, way 31513585, way 29546929, way 312443796, way 230804214, way 230806783, way 122975156, way 124761790, way 124761788, way 124761791, way 207355677, way 122974618, way 123770408, way 123770416, way 123770423, way 123271973, way 207354305, way 123271464, way 207352475, way 215405786, way 72864317, way 123271088, way 29413689, way 123270565, way 123270128, way 207348467, way 161401132, way 123269910, way 296096075, way 296096076, way 83198375, way 123269902, way 123269906, way 207244884, way 123269912, way 123269911, way 207243501, way 123269904, way 82456436, way 207238231, way 123246212, way 82456437, way 123246210, way 123246216, way 207243502, way 123246195, way 123246205, way 123246214, way 123246202, way 82456439, way 123246213, way 123246204, way 123246200, way 33904094, way 123626410, way 123626402, way 122946474, way 122946470, way 122946613, way 122946465, way 123626424, way 122946484, way 123626432, way 122944979, way 123626447, way 123626449, way 123623660, way 123623662, way 123623659, way 123623663, way 123623658, way 123623657, way 124997923, way 124997871, way 124997900, way 82455791, way 82455784, way 207233302, way 124997894, way 82455806, way 208758466, way 82455812, way 124997888, way 124997864, way 29411926, way 124997929, way 124997913, way 124997931, way 29412903, way 124997881, way 35829664, way 124997866, way 70138728, way 105901759, way 105901964, way 70039687, way 209044148, way 124997918, way 70032767, way 40469805, way 40471492, way 92514614, way 70032753, way 92514606, way 70039691, way 92514591, way 69568286, way 69568365, way 44815944, way 124315481, way 207174191, way 207174200, way 207168710, way 207168703, way 207168706, way 207162337, way 207159962, way 207162333, way 313419902, way 313419898, way 207159959, way 207162328, way 207159960, way 207162319, way 220528380, way 220528379, way 220528378, way 124053341, way 124053350, way 212102467, way 233681723, way 212102543, way 212102599, way 212102579, way 212102673, way 218264685, way 220963374, way 323979541, way 218323024, way 218303169, way 212102658, way 212102590, way 218303162, way 207159964, way 218294279, way 207159967, way 207159957, way 220140015, way 220140020, way 220140013, way 220140011, way 220140016, way 220140018, way 320172632, way 220140014, way 320168912, way 220076489, way 220073721, way 220073718, way 220073712, way 220150724, way 320069811, way 320069814, way 220150732, way 220150727, way 208663609, way 208663620, way 208663604, way 320077092, way 208663614, way 206772962, way 206772959, way 206772957, way 206772958, way 206772147, way 206772148, way 206772145, way 206907298, way 206908578, way 206908577, way 206907304, way 319869808, way 206907309, way 206907308, way 220776112, way 322433514, way 206907292, way 206907307, way 206907300, way 206773249, way 206773268, way 206773251, way 320614377, way 206773250, way 206773262, way 206759674, way 220179228, way 320958668, way 320962238, way 320632063, way 320962240, way 320630494, way 220288183, way 220288185, way 60667520, way 220771323, way 60107176, way 220771322, way 220771325, way 60107196, way 60667521, way 60667464, way 60667517, way 60667412, way 60107155, way 29413665, way 52580182, way 52580169, way 206883525, way 390111071, way 60107188, way 52580036, way 264219399, way 264219071, way 264219068, way 206895688, way 264217680, way 52580218, way 206895684, way 29412250, way 206895666, way 265698417, way 206895671, way 79093566, way 53255405, way 78756560, way 53255402, way 390211308, way 79096155, way 53255404, way 390598253, way 79096149, way 385907961, way 79096164, way 206914728, way 385903983, way 78756565, way 385903982, way 385854319, way 385893359, way 53255403, way 178127088, way 385854318, way 178127084, way 178127111, way 30340946, way 385866076, way 30340947, way 167104415, way 299003250, way 206914772, way 206914748, way 206914776, way 40471792, way 123620567, way 124062272, way 40471659, way 124997906, way 61049227, way 385893360, way 385893358, way 81763605, way 78756557, way 61191061, way 377854540, way 78756569, way 79096146, way 207162351, way 207159968, way 54436444, node 21973469, node -30883]}


=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (18) of main
org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Deleted member referenced: {Relation id=2106112 version=128 VT [way 331034994, way 48815631, way 176021661, way 52580121, way 48866562, way 30441688, way 30880333, way 52580122, way 411103221, way 52580115, way 206389387, way 30705743, way 58463384, way 58516733, way 52580040, way 69284977, way 31901060, way 362341136, way 31901059, way 72241609, way 31542010, way 31461710, way 72241552, way 30409992, way 257326752, way 30443786, way 29734155, way 29411837, way 30334572, way 30334570, way 30334569, way 30334568, way 30334567, way 83198158, way 31477358, way 30275093, way 31480092, way 30275348, way 30275041, way 30449068, way 30790201, way 30790196, way 59858866, way 30334067, way 30334065, way 30334066, way 30334064, way 29413448, way 30334059, way 30334061, way 31528031, way 31528028, way 31513585, way 29546929, way 312443796, way 230804214, way 230806783, way 122975156, way 124761790, way 124761788, way 124761791, way 207355677, way 122974618, way 123770408, way 123770416, way 123770423, way 123271973, way 207354305, way 123271464, way 207352475, way 215405786, way 72864317, way 123271088, way 29413689, way 123270565, way 123270128, way 207348467, way 161401132, way 123269910, way 296096075, way 296096076, way 83198375, way 123269902, way 123269906, way 207244884, way 123269912, way 123269911, way 207243501, way 123269904, way 82456436, way 207238231, way 123246212, way 82456437, way 123246210, way 123246216, way 207243502, way 123246195, way 123246205, way 123246214, way 123246202, way 82456439, way 123246213, way 123246204, way 123246200, way 33904094, way 123626410, way 123626402, way 122946474, way 122946470, way 122946613, way 122946465, way 123626424, way 122946484, way 123626432, way 122944979, way 123626447, way 123626449, way 123623660, way 123623662, way 123623659, way 123623663, way 123623658, way 123623657, way 124997923, way 124997871, way 124997900, way 82455791, way 82455784, way 207233302, way 124997894, way 82455806, way 208758466, way 82455812, way 124997888, way 124997864, way 29411926, way 124997929, way 124997913, way 124997931, way 29412903, way 124997881, way 35829664, way 124997866, way 70138728, way 105901759, way 105901964, way 70039687, way 209044148, way 124997918, way 70032767, way 40469805, way 40471492, way 92514614, way 70032753, way 92514606, way 70039691, way 92514591, way 69568286, way 69568365, way 44815944, way 124315481, way 207174191, way 207174200, way 207168710, way 207168703, way 207168706, way 207162337, way 207159962, way 207162333, way 313419902, way 313419898, way 207159959, way 207162328, way 207159960, way 207162319, way 220528380, way 220528379, way 220528378, way 124053341, way 124053350, way 212102467, way 233681723, way 212102543, way 212102599, way 212102579, way 212102673, way 218264685, way 220963374, way 323979541, way 218323024, way 218303169, way 212102658, way 212102590, way 218303162, way 207159964, way 218294279, way 207159967, way 207159957, way 220140015, way 220140020, way 220140013, way 220140011, way 220140016, way 220140018, way 320172632, way 220140014, way 320168912, way 220076489, way 220073721, way 220073718, way 220073712, way 220150724, way 320069811, way 320069814, way 220150732, way 220150727, way 208663609, way 208663620, way 208663604, way 320077092, way 208663614, way 206772962, way 206772959, way 206772957, way 206772958, way 206772147, way 206772148, way 206772145, way 206907298, way 206908578, way 206908577, way 206907304, way 319869808, way 206907309, way 206907308, way 220776112, way 322433514, way 206907292, way 206907307, way 206907300, way 206773249, way 206773268, way 206773251, way 320614377, way 206773250, way 206773262, way 206759674, way 220179228, way 320958668, way 320962238, way 320632063, way 320962240, way 320630494, way 220288183, way 220288185, way 60667520, way 220771323, way 60107176, way 220771322, way 220771325, way 60107196, way 60667521, way 60667464, way 60667517, way 60667412, way 60107155, way 29413665, way 52580182, way 52580169, way 206883525, way 390111071, way 60107188, way 52580036, way 264219399, way 264219071, way 264219068, way 206895688, way 264217680, way 52580218, way 206895684, way 29412250, way 206895666, way 265698417, way 206895671, way 79093566, way 53255405, way 78756560, way 53255402, way 390211308, way 79096155, way 53255404, way 390598253, way 79096149, way 385907961, way 79096164, way 206914728, way 385903983, way 78756565, way 385903982, way 385854319, way 385893359, way 53255403, way 178127088, way 385854318, way 178127084, way 178127111, way 30340946, way 385866076, way 30340947, way 167104415, way 299003250, way 206914772, way 206914748, way 206914776, way 40471792, way 123620567, way 124062272, way 40471659, way 124997906, way 61049227, way 385893360, way 385893358, way 81763605, way 78756557, way 61191061, way 377854540, way 78756569, way 79096146, way 207162351, way 207159968, way 54436444, node 21973469, node -30883]}
	at org.openstreetmap.josm.data.osm.Relation.checkMembers(Relation.java:504)
	at org.openstreetmap.josm.data.osm.Relation.fireMembersChanged(Relation.java:516)
	at org.openstreetmap.josm.data.osm.Relation.setMembers(Relation.java:64)
	at org.openstreetmap.josm.data.osm.Relation.cloneFrom(Relation.java:248)
	at org.openstreetmap.josm.command.ChangeCommand.executeCommand(ChangeCommand.java:81)
	at org.openstreetmap.josm.data.UndoRedoHandler.addNoRedraw(UndoRedoHandler.java:52)
	at org.openstreetmap.josm.data.UndoRedoHandler.add(UndoRedoHandler.java:85)
	at org.openstreetmap.josm.gui.dialogs.relation.actions.SavingAction.applyExistingNonConflictingRelation(SavingAction.java:107)
	at org.openstreetmap.josm.gui.dialogs.relation.actions.SavingAction.applyChanges(SavingAction.java:180)
	at org.openstreetmap.josm.gui.dialogs.relation.actions.OKAction.actionPerformed(OKAction.java:44)
	at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2022)
	at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2348)
	at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:402)
	at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259)
	at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:252)
	at java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:289)
	at java.awt.Component.processMouseEvent(Component.java:6533)
	at javax.swing.JComponent.processMouseEvent(JComponent.java:3324)
	at java.awt.Component.processEvent(Component.java:6298)
	at java.awt.Container.processEvent(Container.java:2236)
	at java.awt.Component.dispatchEventImpl(Component.java:4889)
	at java.awt.Container.dispatchEventImpl(Container.java:2294)
	at java.awt.Component.dispatchEvent(Component.java:4711)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4888)
	at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4525)
	at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4466)
	at java.awt.Container.dispatchEventImpl(Container.java:2280)
	at java.awt.Window.dispatchEventImpl(Window.java:2746)
	at java.awt.Component.dispatchEvent(Component.java:4711)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:758)
	at java.awt.EventQueue.access$500(EventQueue.java:97)
	at java.awt.EventQueue$3.run(EventQueue.java:709)
	at java.awt.EventQueue$3.run(EventQueue.java:703)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
	at java.awt.EventQueue$4.run(EventQueue.java:731)
	at java.awt.EventQueue$4.run(EventQueue.java:729)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:728)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

comment:2 Changed 4 months ago by skyper

Priority: normalmajor

Similar to #13438

comment:3 Changed 7 weeks ago by Don-vip

Milestone: 17.03

comment:4 Changed 7 weeks ago by Don-vip

Resolution: fixed
Status: newclosed

In 11684/josm:

fix #14193 - make sure deleted objects are not added to relations, do not create useless commands if as a result, the relation is not changed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.