Modify

Opened 3 months ago

Closed 3 months ago

Last modified 8 weeks ago

#14125 closed defect (fixed)

unneded warning about missing lanes:*

Reported by: aceman Owned by: team
Priority: minor Milestone: 16.12
Component: Core validator Version: latest
Keywords: Cc:

Description

Hi.
The changeset https://josm.openstreetmap.de/changeset/11371/josm introduced a warning to add lanes:* if there are more than 2 lanes on a road.

The wikipage for "lanes" currently states:
"If the lanes on a two way road are not distributed evenly between the driving directions, the keys lanes:forward=* and lanes:backward=* can be used in addition to the lanes tag."

So please do not show this warning for roads that have an even number of lanes. Those are correctly tagged without lanes:forward/backward.

Thanks.

Attachments (0)

Change History (5)

comment:1 Changed 3 months ago by Klumbumbus

Milestone: 16.12

OK, I didn't know about this implicit rule. The goal of the validator test was to detect cases like https://www.openstreetmap.org/way/4623581 (lanes=4 + turn:lanes:backward=left|through|right)

comment:2 Changed 3 months ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 11406/josm:

fix #14125 - remove warning if lanes>2 and lanes is an even number but no lanes:forward and lanes:backward or oneway is present, remove duplicate line

comment:3 Changed 3 months ago by aceman

Thanks. You can probabbly find another rule that catches that case, not just lanes>2. There should be already checks if sum(lanes:*=) matches lanes= and if count(X:lanes=*) differs for varous X.

Your example could be caught with a rule like, if "number of lanes in any value of a key X:lanes" is more than half the value of lanes, show the warning.

comment:4 Changed 3 months ago by Klumbumbus

Thats not possible without producing false positives again, since lanes=* counts lanes for motorized traffic only while the :lanes extension considers all lanes, e.g. bicycle lanes too.

(There is a similar rule but it is limited to motorways and trunks only https://josm.openstreetmap.de/browser/josm/trunk/data/validator/combinations.mapcss?rev=11406#L449)

comment:5 Changed 8 weeks ago by Klumbumbus

In 11529/josm:

fix #14323, see #14125 - don't warn about odd number of lanes without lanes:forward|backward in roundabouts

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.