Opened 7 years ago
Closed 7 years ago
#14116 closed defect (fixed)
Unexpected error while uploading
| Reported by: | maarten | Owned by: | darya |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Plugin pt_assistant | Version: | latest |
| Keywords: | template_report | Cc: |
Description
I'm trying to upload some edits and I get the error log below. Unfortunately it does not specify where the error originates or what I can do in the osm file to correct it.
After clicking the error away, no upload is made.
I'm using JOSM 11223 on Windows 7 x64 with Java 1.8.0_73
Please provide any additional information below. Attach a screenshot if possible.
URL:http://josm.openstreetmap.de/svn/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2016-11-06 20:18:38 +0100 (Sun, 06 Nov 2016) Build-Date:2016-11-06 21:45:03 Revision:11223 Relative:URL: ^/trunk Identification: JOSM/1.5 (11223 en) Windows 7 64-Bit Memory Usage: 1986 MB / 3637 MB (1356 MB allocated, but free) Java version: 1.8.0_73-b02, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM Screen: \Display0 1920x1200, \Display1 1600x1200 Maximum Screen Size: 1920x1200 VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=%UserProfile%\AppData\LocalLow\Sun\Java\Deployment\cache\6.0\56\1ee8cfb8-28d6746d, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.splashport=49501, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm.jnlp, -Djnlpx.jvm=<java.home>\bin\javaw.exe, -Djnlpx.vmargs=LURqYXZhLnV0aWwuQXJyYXlzLnVzZUxlZ2FjeU1lcmdlU29ydD10cnVlAC1Eam5scC5hcHBsaWNhdGlvbi5ocmVmPWh0dHBzOi8vam9zbS5vcGVuc3RyZWV0bWFwLmRlL2Rvd25sb2FkL2pvc20uam5scAA=] Dataset consistency test: No problems found Plugins: + CustomizePublicTransportStop (0.3) + HouseNumberTaggingTool (32699) + apache-commons (32994) + download_along (32946) + ejml (32680) + ext_tools (33004) + geotools (33042) + jts (32699) + log4j (32699) + measurement (33088) + photo_geotagging (33088) + pt_assistant (33091) + public_transport (33088) + reverter (33088) + routing (33004) + terracer (33088) + turnlanes (33088) + undelete (32699) + utilsplugin2 (33088) + wms-turbo-challenge2 (32914) Map paint styles: + https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&style&zip=1 - https://raw.github.com/gist/1277481/railway.mapcss Last errors/warnings: - W: Unsaved changes - <html>The relation has been changed.<br><br>Do you want to save your changes?</html> - W: Unsaved changes - <html>The relation has been changed.<br><br>Do you want to save your changes?</html> - E: Handled by bug report queue: java.lang.IllegalArgumentException: primitives is empty - E: Handled by bug report queue: java.lang.IllegalArgumentException: primitives is empty - E: Handled by bug report queue: java.lang.IllegalArgumentException: primitives is empty - E: Handled by bug report queue: java.lang.IllegalArgumentException: primitives is empty - E: Handled by bug report queue: java.lang.IllegalArgumentException: primitives is empty - E: java.lang.reflect.InvocationTargetException. Cause: java.lang.IllegalArgumentException: primitives is empty - E: Handled by bug report queue: java.lang.IllegalArgumentException: primitives is empty - E: Handled by bug report queue: java.lang.IllegalArgumentException: primitives is empty === REPORTED CRASH DATA === BugReportExceptionHandler#handleException: No data collected. Warning issued by: BugReportExceptionHandler#handleException === STACK TRACE === Thread: AWT-EventQueue-2 (51) of javawsApplicationThreadGroup java.lang.IllegalArgumentException: primitives is empty at org.openstreetmap.josm.tools.CheckParameterUtil.ensureThat(CheckParameterUtil.java:105) at org.openstreetmap.josm.data.validation.TestError$Builder.build(TestError.java:221) at org.openstreetmap.josm.plugins.pt_assistant.validation.PTAssistantValidatorTest.endTest(PTAssistantValidatorTest.java:429) at org.openstreetmap.josm.actions.upload.ValidateUploadHook.checkUpload(ValidateUploadHook.java:62) at org.openstreetmap.josm.actions.UploadAction.checkPreUploadConditions(UploadAction.java:207) at org.openstreetmap.josm.actions.UploadAction.uploadData(UploadAction.java:231) at org.openstreetmap.josm.actions.UploadAction.actionPerformed(UploadAction.java:271) at javax.swing.AbstractButton.fireActionPerformed(Unknown Source) at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source) at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source) at javax.swing.DefaultButtonModel.setPressed(Unknown Source) at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source) at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source) at java.awt.Component.processMouseEvent(Unknown Source) at javax.swing.JComponent.processMouseEvent(Unknown Source) at java.awt.Component.processEvent(Unknown Source) at java.awt.Container.processEvent(Unknown Source) at java.awt.Component.dispatchEventImpl(Unknown Source) at java.awt.Container.dispatchEventImpl(Unknown Source) at java.awt.Component.dispatchEvent(Unknown Source) at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source) at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source) at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source) at java.awt.Container.dispatchEventImpl(Unknown Source) at java.awt.Window.dispatchEventImpl(Unknown Source) at java.awt.Component.dispatchEvent(Unknown Source) at java.awt.EventQueue.dispatchEventImpl(Unknown Source) at java.awt.EventQueue.access$500(Unknown Source) at java.awt.EventQueue$3.run(Unknown Source) at java.awt.EventQueue$3.run(Unknown Source) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source) at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source) at java.awt.EventQueue$4.run(Unknown Source) at java.awt.EventQueue$4.run(Unknown Source) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source) at java.awt.EventQueue.dispatchEvent(Unknown Source) at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source) at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source) at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source) at java.awt.EventDispatchThread.pumpEvents(Unknown Source) at java.awt.EventDispatchThread.pumpEvents(Unknown Source) at java.awt.EventDispatchThread.run(Unknown Source)
Attachments (0)
Change History (7)
comment:1 by , 7 years ago
comment:2 by , 7 years ago
When I load the OSM file again now, I don't get the error. No matter if I load the pt_assistant, do validation or not.
comment:3 by , 7 years ago
| Component: | Core → Plugin pt_assistant |
|---|---|
| Owner: | changed from to |
comment:4 by , 7 years ago
I've had errors like this again a few times, they did go away when I saved the dataset and disabled the pt_assistant. I now have an error that gives some more info:
Dataset consistency test:
[NO DATASET] {Node id=-140970 version=0 MVT lat=50.91292511379135,lon=5.828106663806342} is referenced by {Relation id=2183128 version=33 MVT [node 4559880545, node 3224021180, node 4558914822, node 4558914821, node -68087, node -73980, node -77249, node -81308, node -84448, node 2096122269, node -112774, node -117108, node -134751, node 2096837790, node 2096837785, node -140970, node 2096837784, node 2095388638, node 2095388649, node 1614675841, node 2095388653, node 2095388631, node 2095388628, way 188078090, way 197662769, way 6773609, way 6773608, way 6773606, way 6773313, way 6773833, way 6773832, way 6773829, way 6773843, way 161028343, way 161028342, way 6773846, way 6773830, way 460222257, way 189381898, way 6773836, way 6773813, way 6773627, way 6773966, way 6773965, way 6773296, way 163593596, way 6773268, way 6773269, way 6773271, way 6773272, way 6773273, way 6773277, way 6773280, way 6773281, way 6773282, way 6773290, way 6773291, way 58878846, way -64421, way 6773306, way 6771625, way 6771596, way 6771595, way 6771588, way 58878809, way 6771590, way 6771577, way 6771411, way 6772240, way 6772255, way 6772239, way 6772242, way 6772187, way 6771790, way 6771838, way 246289321, way 254854817, way 6772034, way 6772033, way 6772185, way 45479330, way 151695548, way 246289324, way 144432381, way 6771647, way 6772953, way 6772955, way 6773053, way 6772968, way 6772970, way 6772980, way 6772982, way 6773011, way 6773003, way 6773001, way 6773064, way 6773075, way 6773074, way 6773073, way 6773070, way 322239124, way 6773016, way 39357861, way 161313667, way 389195318, way 6773020, way 57391510, way 6773083, way 39357857, way 6773042, way 6773023, way 6767092, way 318838563, way 6767083, way 6767074, way 318838562, way 6767101, way 36987197, way 6767118]} but not found in dataset
I got this when I edited a relation outside of the relation while the relation editor was open, causing JOSM to create a conflict.
I'll save this osm file if someone wants to debug it.
And the error is pretty consistent. I can not do anything now without the error surfacing. I need to "suppres this error for this session" to do anything.
Not sure if this is really related to the pt_assistant because when I now try to open the osm file, I get an error: "Relation with external id '2,183,128' refers to a missing primitive with external if '-140,970'".
I'm trying to remember what I did:
- I had the relation editor open. I was working on bus stops
- I removed one bus stop from the relation, copied the node and added that new node to the relation
- I changed the name of both nodes, then realized I shouldn't have, so I undid my changes (CTRL-Z), including the copying of the node
- I exited the relation editor, that's when JOSM created a conflict and the above error came.
I'm guessing the relation still had the link to the new node in it, and when I undid my changes, the node was gone in JOSM but not deleted from the relation.
If I check the osm file, relation 2183128 has a reference to node -140970, but node -140970 is not in the osm file.
I guess this is reproducable.
comment:5 by , 7 years ago
Thanks for the detailed description. As far as I understand, this is because there is a difference between what happens when an old (=existing before the Relation Editor was opened) and a new (=created while the relation editor is open) node is deleted.
When I select and delete an old node, I get the dialog: "Deleting object. Please confirm to remove 1 object. 17 relation are affected". If I confirm and then close the Relation Editor, I get no error message.
When I select and delete a new node, I do not get this dialog. When I close the Relation Editor, I get a DataIntegrityProblemException.
I think this is a problem that is not part of the pt_assistant plugin, i.e. you will still get an error message, just a different one. I will check to make sure pt_assistant works correctly with the old nodes.
comment:7 by , 7 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
The problem that causes this bug is reported in #14193. Minor code modification done in pt_assistant.
I see
PTAssistantValidatorin the log.