#1404 closed defect (fixed)
tagged nodes not diferentiated since 768
| Reported by: | anonymous | Owned by: | framm |
|---|---|---|---|
| Priority: | major | Component: | Core |
| Version: | latest | Keywords: | |
| Cc: |
Description
in rev. 768 some mappaint changes were submitted. Unfortunately, the functionality, where without mappaint, tagged nodes are drawn larger have disappeared
The code:
243 if (n.tagged) {
244 g.drawRect(p.x, p.y, 0, 0);
245 g.drawRect(p.x-2, p.y-2, 4, 4);
246 } else {
247 g.drawRect(p.x-1, p.y-1, 2, 2);
248 }
was replaced with another, that ignores whether the node is tagged or not.
I think the new code:
278 if (fill)
279 g.fillRect(p.x - radius, p.y - radius, size, size);
280 else
281 g.drawRect(p.x - radius, p.y - radius, size, size);
282 }
could be replaced by code, that will double the radius if the node is tagged.
Now it is very hard to spot tagged nodes.
Attachments (0)
Change History (2)
comment:1 Changed 5 years ago by hennejg
- Resolution set to fixed
- Status changed from new to closed
comment:2 Changed 5 years ago by anonymous
Applied in r775.



Fixed by adding support for another config option for tagged, but unselected nodes: mappaint.node.tagged-size.
The default site is 5 pixels, just like for selected nodes.
Patch is submitted and will be committed at the discretion of one of the maintainers.