Modify

#14025 closed enhancement (fixed)

Merge layers is too slow

Reported by: naoliv Owned by: team
Priority: normal Milestone: 16.12
Component: Core Version:
Keywords: performance Cc:

Description

Open all the shapefiles from the attached example and start merging the layers, one by one.
There is a time that it get extremely slow to merge two layers.

With visualvm it's possible to see that most of the time it's executing isUninterestingKey()

https://i.imgur.com/iEfuVN4.png

Isn't it possible to have a faster merging process here?

JOSM:

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-11-20 17:33:33 +0100 (Sun, 20 Nov 2016)
Build-Date:2016-11-21 02:34:51
Revision:11288
Relative:URL: ^/trunk

Identification: JOSM/1.5 (11288 pt_BR) Linux Debian GNU/Linux unstable (sid)
Memory Usage: 247 MB / 4029 MB (101 MB allocated, but free)
Java version: 1.8.0_111-8u111-b14-3-b14, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java package: openjdk-8-jre:amd64-8u111-b14-3
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-11
VM arguments: [-Dawt.useSystemAAFontSettings=on]

Attachments (1)

shapefiles.tar.bz2 (7.6 MB) - added by naoliv 12 months ago.

Change History (7)

Changed 12 months ago by naoliv

Attachment: shapefiles.tar.bz2 added

comment:1 Changed 12 months ago by simon04

In 11290/josm:

see #14025 - Merge layer: log duration

comment:2 Changed 12 months ago by simon04

In 11291/josm:

see #14025 - Store workinprogress/uninteresting/discardable keys in HashSet

comment:3 Changed 12 months ago by simon04

In 11292/josm:

see #14025 - Merge layers performance: run quick/decisive checks first

comment:4 Changed 12 months ago by simon04

Milestone: 16.11

For merging manchas-urbanas and vila
r11289: Merge layer completed in 5 min 39 s
r11292: Merge layer completed in 1 min 18 s

comment:5 Changed 12 months ago by Don-vip

Milestone: 16.1116.12

Milestone renamed

comment:6 Changed 11 months ago by Don-vip

Resolution: fixed
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.