Move some specific tests to country/regional rules

[naoliv]

When #10387 gets fixed, rules like https://josm.openstreetmap.de/browser/josm/trunk/data/validator/highway.mapcss#L11 and https://josm.openstreetmap.de/browser/josm/trunk/data/validator/highway.mapcss#L86 should be moved to more specific (country/regional) rules.

[Klumbumbus]

Yes. The "street name contains ss" info can then be raised to warning or even error level. Currently it produces lots of false positives in switzerland.

[Don-vip]

The checks are language-specific, so we can indeed improve the boundaries file to add official languages, based on information from ISO3166 + ISO639, so we could have something like:

*[language("en")] ... {
 ...
}

and the check would be applied only in countries or subdivisions where English is an official language.

[Klumbumbus]

Replying to Don-vip:

the check would be applied only in countries or subdivisions where English is an official language.

That sounds interresting. However regarding the *[name =~ /(?i).*Strasse.*/] this one is country specific. Germany, Switzerland, Austria and Liechtenstein use the german language but only in Switzerland and Liechtenstein they write the word street with ss instead of ß (strasse instead of straße).

[Klumbumbus]

The rules at Rules should also be adapted.

[Klumbumbus]

Replying to Klumbumbus:

regarding the *[name =~ /(?i).*Strasse.*/] this one is country specific.

Here is my modification of the code:

*[name =~ /(?i).*Strasse.*/][inside("DE,AT")] {
  throwError: tr("street name contains ss");
}
*[name =~ /(?i).*Straße.*/][inside("LI,CH")] {
  throwError: tr("street name contains ß");
}

[Don-vip]

Milestone renamed

[Don-vip]

i18n impact => next milestone

[Klumbumbus]

The test can be anhanced to addr:street

*[addr:street =~ /(?i).*Strasse.*/][inside("DE,AT")],
*[name =~ /(?i).*Strasse.*/][inside("DE,AT")] {
  throwError: tr("street name contains ss");
}
*[addr:street =~ /(?i).*Straße.*/][inside("LI,CH")],
*[name =~ /(?i).*Straße.*/][inside("LI,CH")] {
  throwError: tr("street name contains ß");
}

[Klumbumbus]

In 11439/josm:

• see #13932 - make Straße/Strasse validator test country specific and raise to error level
• feed ignore list

[Klumbumbus]

This ticket is fixed in my eyes. The Straße/Strasse test was adapted and the other test, this one:

way[highway][name =~ /(?i).* (Ave|Blvd|Br|Brg|Cct|Cir|Cl|Cr|Crct|Cres|Crt|Ct|Dr|Drv|Esp|Espl|Hwy|Ln|Mw|Mwy|Pky|Pkwy|Pl|Rd|Qy|Qys|Sq|St|Str|Ter|Tce|Tr|Wy)[.]?$/] {
  throwWarning: tr("abbreviated street name");
  assertMatch: "way highway=unclassified name=\"Foo Ave\"";
  assertMatch: "way highway=unclassified name=\"Foo Ave.\"";
  assertMatch: "way highway=unclassified name=\"Bou Blvd.\"";
  assertMatch: "way highway=unclassified name=\"Bou blvd.\"";
}

is hard to split into different countries/languages. We should keep it as is. We didn't yet receive any tickets about problems with this test.