Modify

Opened 12 months ago

Closed 4 days ago

#13932 closed enhancement (fixed)

Move some specific tests to country/regional rules

Reported by: naoliv Owned by: Don-vip
Priority: normal Milestone: 17.01
Component: Core validator Version:
Keywords: Cc:

Attachments (0)

Change History (23)

comment:1 Changed 12 months ago by Klumbumbus

Yes. The "street name contains ss" info can then be raised to warning or even error level. Currently it produces lots of false positives in switzerland.

comment:2 Changed 11 months ago by Klumbumbus

Milestone: 16.11

comment:3 Changed 11 months ago by Don-vip

The checks are language-specific, so we can indeed improve the boundaries file to add official languages, based on information from ISO3166 + ISO639, so we could have something like:

*[language("en")] ... {
 ...
}

and the check would be applied only in countries or subdivisions where English is an official language.

comment:4 Changed 11 months ago by Don-vip

Owner: changed from team to Don-vip
Status: newassigned

comment:5 in reply to:  3 ; Changed 11 months ago by Klumbumbus

Replying to Don-vip:

the check would be applied only in countries or subdivisions where English is an official language.

That sounds interresting. However regarding the *[name =~ /(?i).*Strasse.*/] this one is country specific. Germany, Switzerland, Austria and Liechtenstein use the german language but only in Switzerland and Liechtenstein they write the word street with ss instead of ß (strasse instead of straße).

comment:6 Changed 11 months ago by Klumbumbus

The rules at Rules should also be adapted.

comment:7 in reply to:  5 Changed 11 months ago by Klumbumbus

Replying to Klumbumbus:

regarding the *[name =~ /(?i).*Strasse.*/] this one is country specific.

Here is my modification of the code:

*[name =~ /(?i).*Strasse.*/][inside("DE,AT")] {
  throwError: tr("street name contains ss");
}
*[name =~ /(?i).*Straße.*/][inside("LI,CH")] {
  throwError: tr("street name contains ß");
}

comment:8 Changed 11 months ago by Don-vip

Milestone: 16.1116.12

Milestone renamed

comment:9 Changed 10 months ago by Don-vip

Milestone: 16.1217.01

i18n impact => next milestone

comment:10 Changed 10 months ago by Klumbumbus

The test can be enhanced to addr:street

*[addr:street =~ /(?i).*Strasse.*/][inside("DE,AT")],
*[name =~ /(?i).*Strasse.*/][inside("DE,AT")] {
  throwError: tr("street name contains ss");
}
*[addr:street =~ /(?i).*Straße.*/][inside("LI,CH")],
*[name =~ /(?i).*Straße.*/][inside("LI,CH")] {
  throwError: tr("street name contains ß");
}
Last edited 10 months ago by Klumbumbus (previous) (diff)

comment:11 Changed 10 months ago by Klumbumbus

In 11439/josm:

  • see #13932 - make Straße/Strasse validator test country specific and raise to error level
  • feed ignore list

comment:12 Changed 9 months ago by Don-vip

Milestone: 17.0117.02

comment:13 Changed 8 months ago by Don-vip

Milestone: 17.0217.03

comment:14 Changed 7 months ago by Don-vip

Milestone: 17.0317.04

comment:15 Changed 6 months ago by Don-vip

Milestone: 17.0417.05

comment:16 Changed 5 months ago by Don-vip

Milestone: 17.0517.06

comment:17 Changed 4 months ago by Don-vip

Milestone: 17.0617.07

comment:18 Changed 3 months ago by Don-vip

Milestone: 17.0717.08

comment:19 Changed 2 months ago by Don-vip

Milestone: 17.0817.09

comment:20 Changed 6 weeks ago by Don-vip

Milestone: 17.0917.10

comment:21 Changed 5 days ago by Don-vip

Milestone: 17.10

comment:22 Changed 4 days ago by Klumbumbus

This ticket is fixed in my eyes. The Straße/Strasse test was adapted and the other test, this one:

way[highway][name =~ /(?i).* (Ave|Blvd|Br|Brg|Cct|Cir|Cl|Cr|Crct|Cres|Crt|Ct|Dr|Drv|Esp|Espl|Hwy|Ln|Mw|Mwy|Pky|Pkwy|Pl|Rd|Qy|Qys|Sq|St|Str|Ter|Tce|Tr|Wy)[.]?$/] {
  throwWarning: tr("abbreviated street name");
  assertMatch: "way highway=unclassified name=\"Foo Ave\"";
  assertMatch: "way highway=unclassified name=\"Foo Ave.\"";
  assertMatch: "way highway=unclassified name=\"Bou Blvd.\"";
  assertMatch: "way highway=unclassified name=\"Bou blvd.\"";
}

is hard to split into different countries/languages. We should keep it as is. We didn't yet receive any tickets about problems with this test.

comment:23 Changed 4 days ago by Klumbumbus

Milestone: 17.01
Resolution: fixed
Status: assignedclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.