Modify

Opened 8 years ago

Closed 7 years ago

#13820 closed defect (fixed)

Crashes when opening incomplete CSV file

Reported by: naoliv Owned by: Don-vip
Priority: normal Milestone:
Component: Plugin opendata Version:
Keywords: template_report Cc:

Description

While opening the attached CSV file (I know that it doesn't have any coordinates), JOSM crashes (while it should give a friendly message saying that the file is invalid)

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-10-18 20:32:20 +0200 (Tue, 18 Oct 2016)
Build-Date:2016-10-19 01:34:39
Revision:11146
Relative:URL: ^/trunk

Identification: JOSM/1.5 (11146 en) Linux Debian GNU/Linux unstable (sid)
Memory Usage: 247 MB / 4029 MB (77 MB allocated, but free)
Java version: 1.8.0_102-8u102-b14.1-2-b14, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java package: openjdk-8-jre:amd64-8u102-b14.1-2
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-9
VM arguments: [-Dawt.useSystemAAFontSettings=on]

Plugins:
+ AddrInterpolation (32699)
+ Create_grid_of_ways (32699)
+ FastDraw (32938)
+ FixAddresses (32796)
+ ImportImagePlugin (32699)
+ OpeningHoursEditor (32699)
+ PicLayer (32796)
+ SimplifyArea (32796)
+ apache-commons (32699)
+ buildings_tools (32944)
+ download_along (32946)
+ editgpx (32699)
+ ejml (32680)
+ geojson (43)
+ geotools (32813)
+ graphview (32796)
+ jogl (1.0.46)
+ jts (32699)
+ kendzi3d (1.0.191)
+ kendzi3d-resources (0.0.1)
+ log4j (32699)
+ measurement (32936)
+ merge-overlap (32699)
+ opendata (32898)
+ pdfimport (32796)
+ photo_geotagging (32699)
+ poly (32699)
+ reverter (32796)
+ tageditor (33021)
+ tagging-preset-tester (32869)
+ todo (30000)
+ turnlanes-tagging (252)
+ turnrestrictions (32796)
+ undelete (32699)
+ utilsplugin2 (32815)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface-DataEntry&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Noname&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features_ryg&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Highway_Nodes&zip=1
- /tmp/bla.mapcss
- https://github.com/OSMBrasil/mapnik-brasil/archive/master.zip 

Validator rules:
+ ${HOME}/git/validador-josm/Rules_Brazilian-Specific.validator.mapcss
+ ${HOME}/git/validador-josm/staging.validator.mapcss

Last errors/warnings:
- W: Failed to load Mappaint styles from '/tmp/bla.mapcss'. Exception was: java.io.FileNotFoundException: /tmp/bla.mapcss (No such file or directory)
- E: java.io.FileNotFoundException: /tmp/bla.mapcss (No such file or directory)
- W: Initializing map style /tmp/bla.mapcss completed in 10 ms (1 errors, 0 warnings)
- W: No valid coordinates have been found.


=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (20) of main
java.lang.IllegalArgumentException: No valid coordinates have been found.
	at org.openstreetmap.josm.plugins.opendata.core.io.tabular.SpreadSheetReader.doParse(SpreadSheetReader.java:155)
	at org.openstreetmap.josm.plugins.opendata.core.io.tabular.CsvReader.parseDataSet(CsvReader.java:48)
	at org.openstreetmap.josm.plugins.opendata.core.io.tabular.CsvImporter.parseDataSet(CsvImporter.java:36)
	at org.openstreetmap.josm.io.OsmImporter.loadLayer(OsmImporter.java:113)
	at org.openstreetmap.josm.io.OsmImporter.importData(OsmImporter.java:90)
	at org.openstreetmap.josm.plugins.opendata.core.io.AbstractImporter.importData(AbstractImporter.java:55)
	at org.openstreetmap.josm.io.FileImporter.importDataHandleExceptions(FileImporter.java:90)
	at org.openstreetmap.josm.actions.OpenFileAction$OpenFileTask.importData(OpenFileAction.java:349)
	at org.openstreetmap.josm.actions.OpenFileAction$OpenFileTask.realRun(OpenFileAction.java:302)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable.doRealRun(PleaseWaitRunnable.java:93)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable.run(PleaseWaitRunnable.java:141)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)

Attachments (1)

crash.csv (154.4 KB ) - added by naoliv 8 years ago.

Download all attachments as: .zip

Change History (4)

by naoliv, 8 years ago

Attachment: crash.csv added

comment:1 by Klumbumbus, 8 years ago

Component: CorePlugin opendata
Owner: changed from team to Don-vip

comment:2 by Klumbumbus, 8 years ago

Ticket #13834 has been marked as a duplicate of this ticket.

comment:3 by Don-vip, 7 years ago

Resolution: fixed
Status: newclosed

Fixed in [o33040:33041].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.