Modify

Opened 14 months ago

Closed 13 months ago

Last modified 12 months ago

#13703 closed enhancement (fixed)

enable mouse wheel scrolling to move layer visibility sliders

Reported by: aseerel4c26 Owned by: team
Priority: normal Milestone: 16.10
Component: Core Version: latest
Keywords: template_report layers visbility scrolling Cc:

Description

What steps will reproduce the problem?

  1. add mapnik background layer
  2. click the layer's visibility options in the layer toolbox
  3. move the mouse pointer over a slider

What is the expected result?

the slider moves up or down depending on scroll direction. This saves mouse clicks.

What happens instead?

the visibility popup closes

Please provide any additional information below. Attach a screenshot if possible.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-09-24 21:53:10 +0200 (Sat, 24 Sep 2016)
Build-Date:2016-09-25 01:36:58
Revision:11051
Relative:URL: ^/trunk

Identification: JOSM/1.5 (11051 de) Linux Linux
Memory Usage: 489 MB / 1820 MB (119 MB allocated, but free)
Java version: 1.8.0_102-b14, Oracle Corporation, OpenJDK 64-Bit Server VM

Plugins:
+ OpeningHoursEditor (32699)
+ buildings_tools (32944)
+ measurement (32936)
+ reverter (32796)
+ terracer (32699)
+ todo (30000)
+ turnrestrictions (32796)
+ undelete (32699)
+ utilsplugin2 (32815)

Last errors/warnings:
- W: Erweiterungen aktualisieren - org.openstreetmap.josm.plugins.PluginHandler$UpdatePluginsMessagePanel[,0,0,0x0,invalid,layout=java.awt.GridBagLayout,alignmentX=0.0,alignmentY=0.0,border=,flags=9,maximumSize=,minimumSize=,preferredSize=]
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$SelectAction@675191bd
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$AddAction@5443f668
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$PassAction@56697af9
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$MarkAction@2c4fe34c

Attachments (0)

Change History (13)

comment:1 Changed 14 months ago by michael2402

Resolution: fixed
Status: newclosed

In 11055/josm:

Fix #13703: Allow mouse wheel to change visibility slider value.

comment:2 Changed 14 months ago by aseerel4c26

Resolution: fixed
Status: closedreopened

wow, great, thank you, Michael! That's fast! :)

Just a minor issue: I would expect the slider movement inverted to what it is now.

Expected: scroll down to decrease visibility. Just like the colour gradient on icon https://josm.openstreetmap.de/browser/trunk/images/dialogs/layerlist/visibility.png symbolizes. E.g. the volume control slider in vlc works also this way (scroll down to decrease volume).

Could you please invert, or was this quite intentional?

comment:3 Changed 14 months ago by aseerel4c26

Second small issue:

  1. hide the layer completely via the checkbox in the popup
  2. try to move a slider via the mousewheel

actual: the slider moves
expected: the slider does not move, since it is inactive anyway. The slider does not move if you try to move the slider my clicking and dragging or by clicking on the slide bar.

comment:4 Changed 14 months ago by michael2402

Thanks for testing that, I'll have a look at it.

comment:5 Changed 14 months ago by aseerel4c26

Third small issue: the scroll-sensitive area is quite small: you seem to need to have your mouse pointer exactly on the slider. It would be nice if the scroll-sensitive area would be a big box which covers the label text and a bit below the slider, too. Not pointing exactly on the slider and scrolling results in the popup being closed – which means you need to move the mouse, click the button, move the mouse on the slider again.

comment:6 Changed 14 months ago by michael2402

I would rather disable the popup closing on mouse wheel scrolling.

I don't like to increase the size of the scroll areas because users may not expect the scroll wheel to have this effect there - and in the end you will get so lazy when pointing your mouse that you move the wrong slider.

comment:7 in reply to:  6 Changed 14 months ago by aseerel4c26

Replying to michael2402:

I would rather disable the popup closing on mouse wheel scrolling.

Okay, fine for me, too!

you will get so lazy when pointing your mouse that you move the wrong slider.

I understand your thoughts. I do not think that this is an issue, because you will notice it directly. All slider actions give you immediate optical feedback (the visual change on the map).

comment:8 Changed 13 months ago by michael2402

Resolution: fixed
Status: reopenedclosed

In 11206/josm:

Fix #13703: Layer visibility popup: Improve mouse wheel hit boxes and make visibility slider more intuitive.

comment:9 Changed 13 months ago by michael2402

Milestone: 16.10

comment:10 Changed 13 months ago by aseerel4c26

Hi Michael, nice, thank you! :)

I have tested it. Some comments:

great: prevent popup close on mouse wheel move
great: mouse wheel listener on label

strange: if the layer is disabled, then scrolling up (normally lowering the slider) does nothing. Scrolling down (normally increasing the slider) reenables the layer, but starts at 0 - like a ghost. Hmm, not really what I would expect. I would expect the slider to become active and start moving from its current position, if it should pick up mouse wheel actions at all (see my comment:3 ). However, not an important feature.

still strange: See my comment:2 : what about inverting the mouse wheel? It is quite un-intuitive now - and contrary to what e.g. JOSM's(!) zoom slider of the map or GIMP or KDE's sound mixer do. Does the mouse wheel work differently for you? Please could you apply a -1 somewhere? ;-)

Thank you again! Features like this is what makes JOSM great!

comment:11 Changed 13 months ago by aseerel4c26

Resolution: fixed
Status: closedreopened

comment:12 Changed 13 months ago by simon04

Resolution: fixed
Status: reopenedclosed

In 11223/josm:

fix #13703 - Fine tune mouse wheel action on layer visibility sliders

  • Invert slider movement wrt. scroll direction
  • Scroll up on hidden layer makes it visible

comment:13 in reply to:  12 Changed 12 months ago by aseerel4c26

Perfect, thanks for the tweak, simon! Thanks again for your work, michael! :-)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.